1470825 - [wpt-sync] Sync PR 11655 - Implement Element.toggleAttribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11655 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11655
Details from upstream follow.

Rakina Zata Amni <[e-mail]> wrote:
>  Implement Element.toggleAttribute
>  
>  Add a new method Element.toggleAttribute(string qualifiedName,
>  optional bool force) that allow toggling the existence of an element’s
>  attribute, similar to Element.classList.toggle.
>  
>  Spec
>  https://dom.spec.whatwg.org/#dom-element-toggleattribute
>  
>  Bug:854960
>  Change-Id: Iab8a1a97dd4e2f8b377bcf590401699f9013aa8a
>  Reviewed-on: https://chromium-review.googlesource.com/1111761
>  WPT-Export-Revision: e828ad8dcee82ae6fd550d8bfa4d540a3e0a6275

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 11655 applied with additional changes from upstream: c3db018b96681af3c73ec331ecc01d38e48b8b10

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=76d4914a7013aa8e852236b78e12e73cb1f358c3

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c95041936285c4a3e084874e7ed8e831eb7eac46

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e8c73b777569d6de2deeda4df49f5a91e3d9ece

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb89cb9606de8931d7ce27af5b4aac29af588c33

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf2949a341603cab2a9f5211fe68d4f006c41731

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 1 tests and 68 subtests
OK     : 1
PASS   : 57
FAIL   : 11

New tests that have failures or other problems:
/dom/nodes/attributes.html
    Basic functionality should be intact. (toggleAttribute): FAIL
    Toggling element with inline style should make inline style disappear: FAIL
    When qualifiedName does not match the Name production, an INVALID_CHARACTER_ERR exception is to be thrown, even if the attribute is already present. (toggleAttribute): FAIL
    When qualifiedName does not match the Name production, an INVALID_CHARACTER_ERR exception is to be thrown. (toggleAttribute): FAIL
    toggleAttribute should lowercase its name argument (mixed case attribute): FAIL
    toggleAttribute should lowercase its name argument (upper case attribute): FAIL
    toggleAttribute should not change the order of previously set attributes.: FAIL
    toggleAttribute should not throw even when qualifiedName starts with 'xmlns': FAIL
    toggleAttribute should set the attribute with the given qualified name: FAIL
    toggleAttribute should set the first attribute with the given name: FAIL

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f941f7b206c31b7590563e4909478e78bd6bad7f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a16aaf33d943
[wpt PR 11655] - Implement Element.toggleAttribute, a=testonly

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a16aaf33d943