Remove support for "components.css"

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P1
normal
RESOLVED FIXED
11 months ago
6 months ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

Trunk
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

11 months ago
We can keep "components.css" around for a few weeks so we can track regressions with the changes in bug 1470830 using artifact builds, but eventually we'll remove support for loading it.
Component: Themes → Layout
Product: Toolkit → Core
Assignee

Comment 1

6 months ago
Should we also restore autofill tests to run in non-headless mode?

https://hg.mozilla.org/mozilla-central/rev/23d4aff26260
Flags: needinfo?(bgrinstead)
Assignee

Updated

6 months ago
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
(In reply to :Paolo Amadini from comment #1)
> Should we also restore autofill tests to run in non-headless mode?
> 
> https://hg.mozilla.org/mozilla-central/rev/23d4aff26260

Yeah it's not needed now that we don't load that as UA sheet. Tracking this down took a while (https://bugzilla.mozilla.org/show_bug.cgi?id=1420229#c34), so if `color: MenuText` got introduced into an existing UA sheet it could save some debugging to have it there. But that seems pretty unlikely, so I'd be fine to remove it.

Brendan, are you aware of any plans to make all xpcshell tests run in the new headless mode (referring to https://bugzilla.mozilla.org/show_bug.cgi?id=1420229#c39)?
Flags: needinfo?(bgrinstead) → needinfo?(bdahl)
(In reply to Brian Grinstead [:bgrins] from comment #3)
> Brendan, are you aware of any plans to make all xpcshell tests run in the
> new headless mode (referring to
> https://bugzilla.mozilla.org/show_bug.cgi?id=1420229#c39)?

No plans that I'm aware of.
Flags: needinfo?(bdahl)

Comment 7

6 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4024ceceab44
Part 1 - Remove support for "components.css". r=bzbarsky
https://hg.mozilla.org/integration/mozilla-inbound/rev/c44903823d66
Part 2 - Resume running formautofill xpcshell tests in non-headless mode. r=bgrins

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4024ceceab44
https://hg.mozilla.org/mozilla-central/rev/c44903823d66
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Blocks: 1507838
You need to log in before you can comment on or make changes to this bug.