Closed Bug 1470991 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 11660 - Revert "Move a test for min-content for a soft-hyphen to wpt"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11660 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11660
Details from upstream follow.

Peng Huang <penghuang@chromium.org> wrote:
>  Revert "Move a test for min-content for a soft-hyphen to wpt"
>  
>  This reverts commit d37409a17a223249ee661ae504def53bf51b4ce9.
>  
>  Reason for revert: external/wpt/css/css-sizing/min-content-soft-hyphen-001.html failed on Windows 10
>  
>  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36928
>  
>  Original change's description:
>  > Move a test for min-content for a soft-hyphen to wpt
>  > 
>  > This tests when the inline-size is [min-content]:
>  > * A `&shy;` produces a break opportunity when computing the
>  >   min-content inline size.
>  > * The hyphen character generated by `&shy;` is included into
>  >   the min-content inline size.
>  > 
>  > Originally developed in [CL:1111895].
>  > 
>  > [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content
>  > [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895
>  > 
>  > Bug: 636993
>  > Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197
>  > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  > Reviewed-on: https://chromium-review.googlesource.com/1113085
>  > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
>  > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#570066}
>  
>  TBR=cbiesinger@chromium.org,kojii@chromium.org
>  
>  Change-Id: I3fb91c7c2d66e775a12994734a14afc566d05a3e
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 636993
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Reviewed-on: https://chromium-review.googlesource.com/1113667
>  Reviewed-by: Peng Huang <penghuang@chromium.org>
>  Commit-Queue: Peng Huang <penghuang@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#570109}
>
PR 11660 applied with additional changes from upstream: cb5379322c3ae9f1fb203d6c0b9bc12e7f6af44d
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02a9f2dfc3f2
[wpt PR 11660] - Revert "Move a test for min-content for a soft-hyphen to wpt", a=testonly
https://hg.mozilla.org/mozilla-central/rev/02a9f2dfc3f2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.