Closed Bug 1470999 Opened 6 years ago Closed 6 years ago

Compress Pause Points data-structure

Categories

(DevTools :: Debugger, enhancement, P2)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

stepping.patch
2.61 KB, patch
jimb
: review+
Details | Diff | Splinter Review 
We're currently seeing a 10% intermittent in win32-optimized mode for dbg-stepping. These failures seem to stem from a memory issues, which was introduced April 15th when we updated Pause Points to include empty points, which increased the size of pause points significantly.

By the way, dbg-stepping has a 55K line file with 37K pause points, so this is where it should show up :)

This patch attempts to remove a large chunk of the memory footprint for pause points on the server.
Assignee: nobody → jlaster
Priority: -- → P2
Attached patch stepping.patch — — Splinter Review 

        Attachment #8987631 -
        Flags: review?(jimb)

    
  
Blocks: 1453815

    
    

    
  
hopefully we can get this try to fail if we re-run the correct chunk 20 times: https://treeherder.mozilla.org/#/jobs?repo=try&revision=23a9d3784760ef7feba6aec2952ab8c764da834d

    
    

    
  
Great! It looks like the fix did its job, try no longer has an OOM.

    
  
Blocks: 1446760
No longer blocks: 1453815

    
    

    
  
Comment on attachment 8987631 [details] [diff] [review]
stepping.patch

Review of attachment 8987631 [details] [diff] [review]:
-----------------------------------------------------------------

Looks beautiful.

        Attachment #8987631 -
        Flags: review?(jimb) → review+

    
    

    
  
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/046feba9b75c
Compress Pause Points data-structure. r=jimb

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/046feba9b75c
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox63:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: