1471072 - iTIP: Canceled occurrences displayed in wrong timezone

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: Proposed fix

When displaying invitations or invitation replies for recurring events with canceled occurrences, said occurrences might get displayed in the wrong timezone, depending on the event.

STR:
0. Thunderbird 60.0b8, Lightning 6.2, Local Time not (currently) equal to UTC
1. Receive an invitation for a recurring event in a different timezone, which is cancelled for at least some of its instances

Expected:
The summary contains local time only

Actual:
In the "Canceled Occurrences" section, times are displayed as specified in the EXDATE property (depending on the client sending the invitation, this could be a local timezone or UTC. Thunderbird always uses UTC)

Reason:
https://dxr.mozilla.org/comm-central/source/calendar/lightning/modules/ltnInvitationUtils.jsm#160 is
> formattedExDates.push(formatter.formatDateTime(exc.date));
not taking the intended display timezone into account (kDefaultTimezone, https://dxr.mozilla.org/comm-central/source/calendar/lightning/modules/ltnInvitationUtils.jsm#137).

I attached a potential fix, feel free to fix it differently (regular diff -u, should apply to both comm-central and comm-release).

Comment 1

[Martin Schröder [:mschroeder]]

Dirk, just a question, does "modifiedOccurrences" in this part of the code also show in the wrong timezone?

Comment 2

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

(In reply to Martin Schröder [:martinschroeder] from comment #1)
> Dirk, just a question, does "modifiedOccurrences" in this part of the code
> also show in the wrong timezone?
From code inspection: no (https://dxr.mozilla.org/comm-central/source/calendar/base/src/calDateTimeFormatter.js#205 calls _getItemDates, which in turn uses the local timezone).

However, I am unable to test that, as Thunderbird doesn't consider modified instances when generating invitations (is that another bug?).

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 8987693 [details] [diff] [review]
Proposed fix

Let's choose a reviewer and see what happens. ;)

Comment 4

[[:MakeMyDay]]

Comment on attachment 8987693 [details] [diff] [review]
Proposed fix

Review of attachment 8987693 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for finding this and submitting a patch! You fixed this in the correct way, so you will get an r+ with the below considered:

The patch is missing a patch header, please add it (look at other chekins or refer to this comment in the bug with your first calendar patch: https://bugzilla.mozilla.org/show_bug.cgi?id=1308324#c1)

The commit message should include at least the reference to the bug,come with a brief summary (and for convenience of our sheriff already with the reference to the reviewer at least if the if the patch is final) like this:

Bug 1471072 - Canceled occurrences of recurring events are displayed in wrong timezone in invitation summaries;r=MakeMyDay

For more complex commit messages are welcome, but for this fix, the above would be sufficient.

Comment 5

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: Fix against comm-central

(In reply to [:MakeMyDay] from comment #4)
> The patch is missing a patch header, please add it
Seems I don't get around installing hg and checking out everything ;)

Here you go; not sure if the patch header for comm-release would be different but the patch itself should apply.

Comment 6

[[:MakeMyDay]]

Comment on attachment 8989469 [details] [diff] [review]
Fix against comm-central

Review of attachment 8989469 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r+.

Let's consider it for uplifting to esr60.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b68b8611671f
Display canceled occurrences of recurring events in correct timezone in invitation summaries. r=MakeMyDay

Comment 8

[Jorg K (CEST = GMT+2)]

TB 60 beta 10, Cal 6.2:
https://hg.mozilla.org/releases/comm-beta/rev/d72158ae7100854cfa522c7acedba1e6f300ae22

Beta (TB 62, Cal 6.4):
https://hg.mozilla.org/releases/comm-beta/rev/8b3976683ae41b6e41647e0501fa7a51694ade03

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr60/rev/1e3d2e7dc562