Choose OOM hooking version to use at build time rather than configure time

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

11 months ago
No description provided.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Updated

11 months ago
Attachment #8987710 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Attachment #8987711 - Flags: review?(core-build-config-reviews) → review?(nfroyd)

Comment 3

11 months ago
mozreview-review
Comment on attachment 8987710 [details]
Bug 1471096 - Vendor rustc_version.

https://reviewboard.mozilla.org/r/252950/#review259794
Attachment #8987710 - Flags: review?(nfroyd) → review+

Comment 4

11 months ago
mozreview-review
Comment on attachment 8987711 [details]
Bug 1471096 - Choose OOM hooking version to use at build time rather than configure time.

https://reviewboard.mozilla.org/r/252952/#review259792

::: toolkit/library/rust/shared/build.rs:15
(Diff revision 1)
> +    } else if std::env::var("MOZ_AUTOMATION").is_ok() {
> +        panic!("Builds on automation must use a version of rust that supports OOM hooking")
> +    }

Just to be clear here, we're OK with not setting bootstrap if somebody has 1.27.x (x != 0) to 1.28-nightlyish?

::: toolkit/library/rust/shared/build.rs:19
(Diff revision 1)
>      // This is a rather awful thing to do, but we're only doing it on
>      // versions of rustc, >= 1.24 < 1.27, that are not going to change
>      // the unstable APIs we use from under us (1.26 being a beta as of
>      // writing, and close to release).

This comment doesn't seem to match up with the setting of bootstrap, since we're setting bootstrap on 1.28 as well?
Attachment #8987711 - Flags: review?(nfroyd) → review+
Assignee

Comment 5

11 months ago
(In reply to Nathan Froyd [:froydnj] from comment #4)
> Comment on attachment 8987711 [details]
> Bug 1471096 - Choose OOM hooking version to use at build time rather than
> configure time.
> 
> https://reviewboard.mozilla.org/r/252952/#review259792
> 
> ::: toolkit/library/rust/shared/build.rs:15
> (Diff revision 1)
> > +    } else if std::env::var("MOZ_AUTOMATION").is_ok() {
> > +        panic!("Builds on automation must use a version of rust that supports OOM hooking")
> > +    }
> 
> Just to be clear here, we're OK with not setting bootstrap if somebody has
> 1.27.x (x != 0) to 1.28-nightlyish?

Except for the builds we produce, yes. (and x == 0 too)
Assignee

Comment 6

11 months ago
BTW, counter intuitively, 1.28.0-nightly > 1.28.0-beta. Let's make things a little clearer by making it "-alpha" rather than "-beta".
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

11 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/daca982d6413
Vendor rustc_version. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/909312d0fc69
Choose OOM hooking version to use at build time rather than configure time. r=froydnj

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/daca982d6413
https://hg.mozilla.org/mozilla-central/rev/909312d0fc69
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.