1471102 - Move more stuff from ExtensionUtils.jsm to ExtensionCommon.jsm

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Kris Maglione [:kmag]]

ExtensionUtils.jsm has gotten bloated again with things that aren't needed before extension functionality starts up in a process. This is bad for content process base memory.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1471102: Move more code out of ExtensionUtils.jsm.

Review commit: https://reviewboard.mozilla.org/r/252960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252960/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8987715 [details]
Bug 1471102: Move more code out of ExtensionUtils.jsm.

https://reviewboard.mozilla.org/r/252960/#review260470

This looks fine functionally.  But I'm confused about the distinction between ExtensionCommon and ExtensionUtils, it looks like they're generally both loaded into most processes?  From the original bug report, I gather that the difference is about exactly how early each is loaded?  In any case, can you add a comment (probably to the top of ExtensionUtils) explaining guidelines for what to put where.

Comment 3

[Kris Maglione [:kmag]]

(In reply to Andrew Swan [:aswan] from comment #2)
> This looks fine functionally.  But I'm confused about the distinction
> between ExtensionCommon and ExtensionUtils, it looks like they're generally
> both loaded into most processes?  From the original bug report, I gather
> that the difference is about exactly how early each is loaded?  In any case,
> can you add a comment (probably to the top of ExtensionUtils) explaining
> guidelines for what to put where.

Right, it's about how early it gets loaded. ExtensionUtils gets loaded into every process very early, regardless of whether we need to run any extension functionality there. ExtensionCommon only gets loaded once we need to run some part of an extension.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43fb0b6e28d50744ffa778d6cf5373d14689135e
Bug 1471102: Move more code out of ExtensionUtils.jsm. r=aswan

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/43fb0b6e28d5

Comment 6

[Vlad Jiman]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 7

[jay mith]

In the meantime, if you want a mitigation for this very specific problem, closing the database and re-opening it should trigger the upgrade to run and things to then work. Note, however, that what you may be seeing in the field is users experiencing completely broken QuotaManager/IndexedDB setups. We're seeing a lot of that in our ActivityStream telemetry and are working to fix the underlying issues. (Which is to say, you may have identified a different bug here than your users are experiencing/reporting.)

I'm going to leave the needinfo on me to look into this again later.

these are the websites
https://tr.sex-open.com/
https://tr.sex-open.com/big-butt