Closed
Bug 1471131
Opened 6 years ago
Closed 6 years ago
mips64 Trampoline-mips64
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: qiaopengcheng-hf, Assigned: qiaopengcheng-hf)
Details
Attachments
(1 file, 1 obsolete file)
1.57 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20180621135500 Steps to reproduce: cd the top inbound directory, ./mach configure ./mach build Actual results: compile source code error at file js/src/jit/mips64/Trampoline-mips64.cpp:728 MoveOperand from; using delete function, Expected results: should compile successfully.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8987738 -
Flags: review?(jdemooij)
Comment 2•6 years ago
|
||
Comment on attachment 8987738 [details] [diff] [review] Fix compiling error on mips64 Review of attachment 8987738 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but there's a similar one in Trampoline-mips32.cpp: https://searchfox.org/mozilla-central/rev/39b790b29543a4718d876d8ca3fd179d82fc24f7/js/src/jit/mips32/Trampoline-mips32.cpp#761 Mind removing that line too? Thanks!
Attachment #8987738 -
Flags: review?(jdemooij) → review+
Updated•6 years ago
|
Assignee: nobody → qiaopengcheng-hf
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #2) > Comment on attachment 8987738 [details] [diff] [review] > Fix compiling error on mips64 > > Review of attachment 8987738 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, but there's a similar one in Trampoline-mips32.cpp: > > https://searchfox.org/mozilla-central/rev/ > 39b790b29543a4718d876d8ca3fd179d82fc24f7/js/src/jit/mips32/Trampoline-mips32. > cpp#761 > > Mind removing that line too? Thanks! Ok, I'll reupload.
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8987738 -
Attachment is obsolete: true
Attachment #8988029 -
Flags: review?(jdemooij)
Comment 5•6 years ago
|
||
Comment on attachment 8988029 [details] [diff] [review] mips trampoline compiling error Review of attachment 8988029 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8988029 -
Flags: review?(jdemooij) → review+
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1148c907376b Fix compiling error of Trampoline on mips. r=jandem
Keywords: checkin-needed
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1148c907376b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
status-firefox62:
--- → affected
Updated•6 years ago
|
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•