Closed Bug 1471136 Opened Last year Closed Last year

Update fuzzer shell flags combinations

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: gkw, Assigned: gkw)

References

Details

Attachments

(1 file)

As per bug 1461689 comment 18, there are several flags that might be worth updating into the list of flags that fuzzers use, e.g. "--enable-avx" and "--no-avx".
Priority: -- → P3
Assignee: nobody → nth10sd
Status: NEW → ASSIGNED
I decided to put an arbitrary value of 2 for --gc-zeal as gczeal(2) triggers a more comprehensive gc and I've also seen bugs caused by --gc-zeal=<some number> but does not reproduce with gczeal(<some number>);
Comment on attachment 9003384 [details]
Summary: Update fuzzer shell flags combinations

Jan de Mooij [:jandem] has approved the revision.
Attachment #9003384 - Flags: review+
(In reply to Gary Kwong [:gkw] [:nth10sd] - in-n-out; clearing backlog from comment #2)
Zeal mode 2 does period full, non-incremental GCs.  I'd suggest also adding mode 10, which does periodic incremental GCs in many slices.
I think there are so many legit gczeal combinations, that we shouldn't add them to the shell flags at all. Instead, the fuzzers can call gczeal() in the shell directly with various parameters.
(In reply to Christian Holler (:decoder) from comment #5)
> I think there are so many legit gczeal combinations, that we shouldn't add
> them to the shell flags at all. Instead, the fuzzers can call gczeal() in
> the shell directly with various parameters.

You're right, this is most of the cases. However, bug 1285074 is an example of a testcase that needs both --gc-zeal and gczeal() as I mentioned above.

Thus, I'd add a minimal set of 2 numbers for --gc-zeal - 2 and 10, as :jonco mentions in comment 4. Anything else will go into random choices of gczeal().
Setting checkin-needed. Not sure if it's the right thing to do - Lando via Phabricator mentions that my commit access has expired.
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fc9e0fc33de
Summary: Update fuzzer shell flags combinations r=jandem
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6fc9e0fc33de
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1488553
You need to log in before you can comment on or make changes to this bug.