1471136 - Update fuzzer shell flags combinations

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

As per bug 1461689 comment 18, there are several flags that might be worth updating into the list of flags that fuzzers use, e.g. "--enable-avx" and "--no-avx".

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Summary: Update fuzzer shell flags combinations

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I decided to put an arbitrary value of 2 for --gc-zeal as gczeal(2) triggers a more comprehensive gc and I've also seen bugs caused by --gc-zeal=<some number> but does not reproduce with gczeal(<some number>);

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 9003384 [details]
Summary: Update fuzzer shell flags combinations

Jan de Mooij [:jandem] has approved the revision.

Comment 4

[Jon Coppeard (:jonco)]

(In reply to Gary Kwong [:gkw] [:nth10sd] - in-n-out; clearing backlog from comment #2)
Zeal mode 2 does period full, non-incremental GCs.  I'd suggest also adding mode 10, which does periodic incremental GCs in many slices.

Comment 5

[Christian Holler (:decoder)]

I think there are so many legit gczeal combinations, that we shouldn't add them to the shell flags at all. Instead, the fuzzers can call gczeal() in the shell directly with various parameters.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Christian Holler (:decoder) from comment #5)
> I think there are so many legit gczeal combinations, that we shouldn't add
> them to the shell flags at all. Instead, the fuzzers can call gczeal() in
> the shell directly with various parameters.

You're right, this is most of the cases. However, bug 1285074 is an example of a testcase that needs both --gc-zeal and gczeal() as I mentioned above.

Thus, I'd add a minimal set of 2 numbers for --gc-zeal - 2 and 10, as :jonco mentions in comment 4. Anything else will go into random choices of gczeal().

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Setting checkin-needed. Not sure if it's the right thing to do - Lando via Phabricator mentions that my commit access has expired.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fc9e0fc33de
Summary: Update fuzzer shell flags combinations r=jandem

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6fc9e0fc33de