Closed Bug 1471147 Opened 6 years ago Closed 6 years ago

Enable Rust coverage in Windows builds

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(3 files)

Rust coverage collection is working with very limited changes on Windows, so we might start to enable it.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8987775 - Flags: review?(jmaher)
Comment on attachment 8987775 [details] [diff] [review]
Add Rust nightly toolchain definition for Windows

Review of attachment 8987775 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/toolchain/windows.yml
@@ +164,5 @@
> +            '--host', 'x86_64-pc-windows-msvc',
> +            '--target', 'x86_64-pc-windows-msvc',
> +            '--target', 'i686-pc-windows-msvc',
> +        ]
> +        toolchain-artifact: public/build/rustc.tar.bz2

will this path conflict with a non nightly release of rustc.tar.bz2?
Attachment #8987775 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #2)
> Comment on attachment 8987775 [details] [diff] [review]
> Add Rust nightly toolchain definition for Windows
> 
> Review of attachment 8987775 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: taskcluster/ci/toolchain/windows.yml
> @@ +164,5 @@
> > +            '--host', 'x86_64-pc-windows-msvc',
> > +            '--target', 'x86_64-pc-windows-msvc',
> > +            '--target', 'i686-pc-windows-msvc',
> > +        ]
> > +        toolchain-artifact: public/build/rustc.tar.bz2
> 
> will this path conflict with a non nightly release of rustc.tar.bz2?

It shouldn't, in the Linux case both linux64-rust-nightly and linux64-rust-1.24 have toolchain-artifact: public/build/rustc.tar.xz.
Attachment #8987788 - Flags: review?(jmaher)
Attachment #8987787 - Flags: review?(jmaher) → review+
Comment on attachment 8987788 [details] [diff] [review]
Enable Rust coverage on Windows

Review of attachment 8987788 [details] [diff] [review]:
-----------------------------------------------------------------

this is a rubber stamp!
Attachment #8987788 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d37fde9b63
Add Rust nightly toolchain definition for Windows. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3b6f7c558c
Use Rust nightly toolchain on Windows code coverage builds. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/622c8ecf9452
Enable Rust coverage on Windows. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/e3d37fde9b63
https://hg.mozilla.org/mozilla-central/rev/0c3b6f7c558c
https://hg.mozilla.org/mozilla-central/rev/622c8ecf9452
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: