Closed
Bug 1471147
Opened 6 years ago
Closed 6 years ago
Enable Rust coverage in Windows builds
Categories
(Testing :: Code Coverage, enhancement)
Testing
Code Coverage
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(3 files)
1.73 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
904 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Rust coverage collection is working with very limited changes on Windows, so we might start to enable it.
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8987775 [details] [diff] [review] Add Rust nightly toolchain definition for Windows Review of attachment 8987775 [details] [diff] [review]: ----------------------------------------------------------------- ::: taskcluster/ci/toolchain/windows.yml @@ +164,5 @@ > + '--host', 'x86_64-pc-windows-msvc', > + '--target', 'x86_64-pc-windows-msvc', > + '--target', 'i686-pc-windows-msvc', > + ] > + toolchain-artifact: public/build/rustc.tar.bz2 will this path conflict with a non nightly release of rustc.tar.bz2?
Attachment #8987775 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #2) > Comment on attachment 8987775 [details] [diff] [review] > Add Rust nightly toolchain definition for Windows > > Review of attachment 8987775 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: taskcluster/ci/toolchain/windows.yml > @@ +164,5 @@ > > + '--host', 'x86_64-pc-windows-msvc', > > + '--target', 'x86_64-pc-windows-msvc', > > + '--target', 'i686-pc-windows-msvc', > > + ] > > + toolchain-artifact: public/build/rustc.tar.bz2 > > will this path conflict with a non nightly release of rustc.tar.bz2? It shouldn't, in the Linux case both linux64-rust-nightly and linux64-rust-1.24 have toolchain-artifact: public/build/rustc.tar.xz.
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8987787 -
Flags: review?(jmaher)
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #8987788 -
Flags: review?(jmaher)
Updated•6 years ago
|
Attachment #8987787 -
Flags: review?(jmaher) → review+
Comment 6•6 years ago
|
||
Comment on attachment 8987788 [details] [diff] [review] Enable Rust coverage on Windows Review of attachment 8987788 [details] [diff] [review]: ----------------------------------------------------------------- this is a rubber stamp!
Attachment #8987788 -
Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d37fde9b63 Add Rust nightly toolchain definition for Windows. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3b6f7c558c Use Rust nightly toolchain on Windows code coverage builds. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/622c8ecf9452 Enable Rust coverage on Windows. r=jmaher
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3d37fde9b63 https://hg.mozilla.org/mozilla-central/rev/0c3b6f7c558c https://hg.mozilla.org/mozilla-central/rev/622c8ecf9452
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•