1471153 - Standardize DOM Panel initialization

Status: NEW

(DevTools :: DOM, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Per the following RFC:
  https://github.com/devtools-html/rfcs/issues/48
And in order to unblock Promise.jsm removal and especially allow landing bug 1388054, we should refactor main.js to stop being evaluated as a document script, but rather it be loaded as a module, via DevTools module loader.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1471153 - Standardize initialization of DOM panel.

Review commit: https://reviewboard.mozilla.org/r/253052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253052/

Comment 2

[Alexandre Poirot [:ochameau]]

It looks like DOM Panel supports launchpad workflow or something similar.
This patch may break it in utils.js, but it isn't clear if this workflow is still supported/still works.
I'm open to suggestion to tweak that patch to keep this working.

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Alexandre Poirot [:ochameau] from comment #2)
> It looks like DOM Panel supports launchpad workflow or something similar.
> This patch may break it in utils.js, but it isn't clear if this workflow is
> still supported/still works.
> I'm open to suggestion to tweak that patch to keep this working.

I stumbled upon this for some reason during the accessibility panel review and asked about it already. DOM panel was supporting a "launchpad-like" workflow, but I think Honza already mentioned that this was no longer maintained. We can probably do some cleanup in a follow up. For the time being, breaking this is fine IMO.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8987777 [details]
Bug 1471153 - Standardize initialization of DOM panel.

https://reviewboard.mozilla.org/r/253052/#review259758

Thanks! Just spotted two minor issues to fix.

::: devtools/client/dom/panel.js:19
(Diff revision 1)
>  
>  /**
>   * This object represents DOM panel. It's responsibility is to
>   * render Document Object Model of the current debugger target.
>   */
>  function DomPanel(iframeWindow, toolbox) {

We could remove this iframe argument.

::: devtools/client/jar.mn
(Diff revision 1)
>      content/shared/widgets/spectrum.css (shared/widgets/spectrum.css)
>      content/aboutdebugging/aboutdebugging.xhtml (aboutdebugging/aboutdebugging.xhtml)
>      content/aboutdebugging/aboutdebugging.css (aboutdebugging/aboutdebugging.css)
>      content/responsive.html/index.xhtml (responsive.html/index.xhtml)
>      content/dom/index.html (dom/index.html)
> -    content/dom/main.js (dom/main.js)

main.js is still referenced in devtools/client/dom/index.html

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8987777 [details]
Bug 1471153 - Standardize initialization of DOM panel.

https://reviewboard.mozilla.org/r/253052/#review260614

Looks good, thanks for the patch Alex!

R+ assuming that Julian's comments are resolved and try is green.

Honza