Closed
Bug 1471166
Opened 6 years ago
Closed 6 years ago
Update grcov to version 0.1.40
Categories
(Testing :: Code Coverage, enhancement)
Testing
Code Coverage
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
Details
Attachments
(1 file)
|
4.30 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
With the latest version of grcov, we will no longer need to zip the gcda files just for passing them to grcov, as it supports reading files from both ZIPs and directories (previously it only supported either ZIPs or directories, now you can give it anything). https://dxr.mozilla.org/mozilla-central/rev/681eb7dfa324dd50403c382888929ea8b8b11b00/testing/mozharness/mozharness/mozilla/testing/codecoverage.py#261
|
Assignee | |
Comment 1•6 years ago
|
||
This should be a small perf win, especially for per-test mode where we are running grcov many times.
|
|
Assignee | |
Updated•6 years ago
|
Summary: Update grcov to latest version → Update grcov to version 0.1.40
|
|
Assignee | |
Comment 2•6 years ago
|
||
And I forgot to mention that this should also fix an intermittent failure we are seeing on Windows, due to disk space exhaustion.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7512244d64b8323c044508bf5e0aea81ab3fa505.
|
||
Comment 5•6 years ago
|
||
Comment on attachment 8988217 [details] [diff] [review] Patch Review of attachment 8988217 [details] [diff] [review]: ----------------------------------------------------------------- oh, more rubber stamping here
Attachment #8988217 -
Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3bddc4c52504 Update grcov to v0.1.40, stop zipping gcda files. r=jmaher
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3bddc4c52504
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•