Closed Bug 1471177 Opened 3 years ago Closed 3 years ago

Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.

Categories

(Core :: MFBT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

clang has its own libc++ implementation, which implements wchat_t functions. This causes problems with mingw clang builds. I think that we should use those only when building against GCC libstdc++.
Comment on attachment 8987797 [details]
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.

https://reviewboard.mozilla.org/r/253076/#review259654
Attachment #8987797 - Flags: review?(nfroyd) → review+
Comment on attachment 8987797 [details]
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8987797 - Flags: approval-mozilla-esr60?
Pushed by jacek@codeweavers.com:
https://hg.mozilla.org/integration/autoland/rev/23fb443b2214
Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/23fb443b2214
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment on attachment 8987797 [details]
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.

Makes downstream maintenance easier for Tor. Approved for ESR 60.2.
Attachment #8987797 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.