Closed Bug 1471194 Opened 3 years ago Closed 3 years ago

browser/components/sessionstore/test/unit/test_scalar_worker_restarts.js is going to permafail when the Gecko version number is bumped to 64 on 2018-09-04

Categories

(Firefox :: Session Restore, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + verified

People

(Reporter: NarcisB, Assigned: mikedeboer)

References

Details

Attachments

(1 file)

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=26c0f189327c7888e1505766ca78be45f559f990&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&selectedJob=184890042

Fail: browser/components/sessionstore/test/unit/test_scalar_worker_restarts.js | test_worker_restart - [test_worker_restart : 38] Should be increased with one hit. - "undefined" == 1
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=184890042&repo=try&lineNumber=2095
Flags: needinfo?(mdeboer)
Summary: Xpcshell tests are going to permafail when the Gecko version number is bumped to 64 on 2018-09-04 → browser/components/sessionstore/test/unit/test_scalar_worker_restarts.js is going to permafail when the Gecko version number is bumped to 64 on 2018-09-04
AFAICT this is due to the browser.session.restore.worker_restart_count scalar expiring in 64
Indeed and I think that we've gathered enough data to remove this probe. I'll whip up a patch to remove it.
Flags: needinfo?(mdeboer)
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Priority: -- → P1
See Also: → 1402267
Comment on attachment 8991582 [details]
Bug 1471194 - Remove the expiring scalar Telemetry probe 'worker_restart_count', since it has served its purpose well.

https://reviewboard.mozilla.org/r/256516/#review264542

Removing probes! Thanks for cleaning up our data collection, this lgtm.
Attachment #8991582 - Flags: review?(liuche) → review+
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/631f5d3fa810
Remove the expiring scalar Telemetry probe 'worker_restart_count', since it has served its purpose well. r=liuche
https://hg.mozilla.org/mozilla-central/rev/631f5d3fa810
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.