1471214 - Dictionary copy operator do not copy DisctionaryBase::mIsAnyMemberPresent member

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Jean-Yves Avenard [:jya]]

Say you have:
Dictionary foo;
with foo.IsAnyMemberPresent() = true

Dictionary blah = foo;

blah.IsAnyMemberPresent() will return false

The binding code, for each dictionary will generate a copy constructor, however that copy constructor doesn't call the DictionaryBase copy constructor.

As such, after a copy DictionaryBase::mIsAnyMemberPresent is always false.

Comment 1

[Phabricator Automation]

Attachment: Bug 1471214 - Ensure that DictionaryBase copy constructor is called. r?bz

Such that a call to dictionary.IsAnyMemberPresent() will return the correct value.

Comment 2

[Phabricator Automation]

Comment on attachment 8987823 [details]
Bug 1471214 - Ensure that DictionaryBase copy constructor is called. r?bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D1829

Comment 3

[Phabricator Automation]

Comment on attachment 8987823 [details]
Bug 1471214 - Ensure that DictionaryBase copy constructor is called. r?bz

Boris Zbarsky [:bz] (no decent commit message means r-) has requested changes to the revision.

https://phabricator.services.mozilla.com/D1829

Comment 4

[Phabricator Automation]

Comment on attachment 8987823 [details]
Bug 1471214 - Ensure that DictionaryBase copy constructor is called. r?bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D1829

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9da8a5d80b98
Ensure that DictionaryBase copy constructor is called. r=bzbarsky

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9da8a5d80b98