1471228 - downloads.m.o page potentially (still) uses version releases instead of the latest bouncer aliases for esr60

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, enhancement)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Not sure if this is right or not, but I thought it's worth filing anyway.

While we shipped 61.0 earlier today we noticed that all occurrences of firefox downalods from here[1] were pointing at links such as this[2]. Having a version release number there instead of the "firefox-esr-next-latest-ssl" alias which I was expecting.

I'm not sure if this is expected or not. I know in bug 1387622 we added those extra aliases so that we don't have that lag anymore. For most of the releaes what we used to have historically was:

mark releases as shipped in Ship-it => update in product details automatically => get picked up by bedrock => show on downdloads page. (this whole thing used to take up to 15-20 mins sometimes).

Then we switched to aliases so that as soon as we mark the bouncer aliases correctly, we started getting those builds from the downloads page.

I was wondering if this edge case of esr60 (until 52 is history) is expected to be this way or did we miss it when we created the new branch. Specifically, do we actually use that firefox-esr-next-latest-ssl in bedrock or do we prefer the classic way of updating it when we deal with overlapping ESR releases?

P.S. But if this is an issue, we won't likely hit this for another six releases, until we branch-off 68esr. 

[1]: https://www.mozilla.org/en-US/firefox/organizations/all/
[2]: https://download.mozilla.org/?product=firefox-60.1.0esr-SSL&os=osx&lang=ar

Comment 1

[Paul [:pmac] McLanahan]

We have an issue in our github repo for this:

https://github.com/mozilla/bedrock/issues/5684

The alias for 'esr-next-latest' was not added in 1387622 I don't think. We did get, and have been using, the 'esr-latest' alias in that bug, but the other ESR alias was only added recently in bug 1408868. So we do hope to have that done soon, but we do have other higher-priority work at the moment since those links are working and, as you said, this particular alias is only used every time a new major ESR version is released. We would prefer to use the "*-latest" aliases for everything on the site, but this last one just isn't done yet.

Thanks for filing. I'll update this bug when it's completed.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Paul [:pmac] McLanahan ⏰ET needinfo? me from comment #1)
> We have an issue in our github repo for this:
> 
> https://github.com/mozilla/bedrock/issues/5684
> 
> The alias for 'esr-next-latest' was not added in 1387622 I don't think. We
> did get, and have been using, the 'esr-latest' alias in that bug, but the
> other ESR alias was only added recently in bug 1408868. So we do hope to
> have that done soon, but we do have other higher-priority work at the moment
> since those links are working and, as you said, this particular alias is
> only used every time a new major ESR version is released. We would prefer to
> use the "*-latest" aliases for everything on the site, but this last one
> just isn't done yet.
> 
> Thanks for filing. I'll update this bug when it's completed.

Sorry for late reply here. Thanks for confirming this. No worries, no rush, as you said - this is not priority, at least not for another six releases as we're covered but it's worth keeping it under the radar. Thanks!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

The upstream GitHub issue was closed - is this bug fixed?

Comment 4

[Paul [:pmac] McLanahan]

Yes! My apologies for missing this for closing. It was fixed in:

https://github.com/mozilla/bedrock/pull/7266

Based on bug 1408868 being fixed. Thanks for the ping.