Closed
Bug 1471234
Opened 6 years ago
Closed 6 years ago
Assert that LifoAlloc::steal does not leak any chunks.
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
|
996 bytes,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
LifoAlloc::steal is used to transfer all the chunks from a LifoAlloc to another empty one. We should ensure that the target is indeed empty to avoid uncontrolled free of our BumpChunks.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8987833 -
Flags: review?(tcampbell)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8987833 [details] [diff] [review] Assert LifoAlloc::steal does not trash BumpChunks. Review of attachment 8987833 [details] [diff] [review]: ----------------------------------------------------------------- Good idea.
Attachment #8987833 -
Flags: review?(tcampbell) → review+
Pushed by npierron@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a2878ea8e1f0 Assert LifoAlloc::steal does not trash BumpChunks. r=tcampbell
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a2878ea8e1f0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•