1471245 - Replace openNewTabAndToolbox by openNewTabAndConsole in webconsole tests

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

usually we need the hud, which we get from the toolbox using 

```js
const hud = toolbox.getCurrentPanel().hud;
```

We should always use openNewTabAndConsole, and then add an access to the toolbox in hud if we need it toolbox access in the test.

See https://searchfox.org/mozilla-central/search?q=toolbox.getCurrentPanel().hud&case=false&regexp=false&path=devtools%2Fclient%2Fwebconsole%2F to see all hug retrieval through toolbox that might be changed.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1471245 - Replace openNewTabAndToolbox by openNewTabAndConsole in webconsole tests; r=bgrins.

This is done in all the tests that don't need an explicit
reference to the toolbox.

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 9009614 [details]
Bug 1471245 - Replace openNewTabAndToolbox by openNewTabAndConsole in webconsole tests; r=bgrins.

Brian Grinstead [:bgrins] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2aa3365b87b1
Replace openNewTabAndToolbox by openNewTabAndConsole in webconsole tests; r=bgrins.

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2aa3365b87b1