Closed Bug 1471254 Opened 2 years ago Closed 2 years ago

Add package name to crash data

Categories

(GeckoView :: General, defect, P1)

59 Branch
defect

Tracking

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: snorp, Assigned: snorp)

Details

(Whiteboard: [geckoview:klar] [geckoview:crow])

Attachments

(1 file)

We need a way to tell if a crash came from Fennec vs Focus or another GV-using app. Sending the package name seems like the easiest way to accomplish this.
Whiteboard: [geckoview:klar] [geckoview:crow]
Assignee: nobody → snorp
Priority: -- → P1
Attachment #8989235 - Flags: review?(esawin) → review?(droeh)
We should uplift this fix to Beta 62.
Comment on attachment 8989235 [details]
Bug 1471254 - Add Android package name to crash reports

https://reviewboard.mozilla.org/r/254280/#review261278

Looks good to me other than a nit for the commit message.

::: commit-message-e97bd:1
(Diff revision 1)
> +Bug 1471254 - Add Android package name to crash reports r=esawin

Should be r=droeh :)
Attachment #8989235 - Flags: review?(droeh) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e21a6711a990
Add Android package name to crash reports r=droeh
https://hg.mozilla.org/mozilla-central/rev/e21a6711a990
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Comment on attachment 8989235 [details]
Bug 1471254 - Add Android package name to crash reports

Approval Request Comment
[Feature/Bug causing the regression]: GeckoView
[User impact if declined]: Unable to determine which app a Gecko crash comes from
[Is this code covered by automated tests?]: Yes, in that crashes are reported from tests.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only adds a field to crash data
[String changes made/needed]: None
Attachment #8989235 - Flags: approval-mozilla-beta?
Comment on attachment 8989235 [details]
Bug 1471254 - Add Android package name to crash reports

Useful for crash diagnosis, let's uplift for beta 8.
Attachment #8989235 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → GeckoView
Version: Firefox 59 → 59 Branch
Target Milestone: Firefox 63 → mozilla63
You need to log in before you can comment on or make changes to this bug.