Closed
Bug 1471263
Opened 7 years ago
Closed 7 years ago
Re-enable the test_show_field_specific_error_on_addresschange test in browser_shippingaddresschange_error.js
Categories
(Firefox :: WebPayments UI, enhancement, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jaws, Assigned: sfoster)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
Bug 1429260 added a skip() at the end of test_show_field_specific_error but skipping this change was done after I granted review.
https://reviewboard.mozilla.org/r/246638/diff/2-3/
(I granted review on version 1 of the diff and it looks like the skip was added after a rebase)
Sam, can you please remove the skip() and presumably get the test passing?
Flags: needinfo?(sfoster)
|
||
Updated•7 years ago
|
Whiteboard: [webpayments] [triage]
|
|
||
Updated•7 years ago
|
Priority: -- → P2
Whiteboard: [webpayments] [triage] → [webpayments]
|
Assignee | |
Comment 1•7 years ago
|
||
(In reply to (away 7/1-7/7) Jared Wein [:jaws] (please needinfo? me) from comment #0)
> Sam, can you please remove the skip() and presumably get the test passing?
I'll look into this, sorry for the churn.
Assignee: nobody → sfoster
Flags: needinfo?(sfoster)
|
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8988016 [details]
Bug 1471263 - Unbork and un-skip the test_show_field_specific_error_on_addresschange test.
https://reviewboard.mozilla.org/r/253272/#review259868
Attachment #8988016 -
Flags: review+
|
Reporter | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8988016 [details]
Bug 1471263 - Unbork and un-skip the test_show_field_specific_error_on_addresschange test.
https://reviewboard.mozilla.org/r/253272/#review259908
Attachment #8988016 -
Flags: review?(jaws) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74c677c459ab
Unbork and un-skip the test_show_field_specific_error_on_addresschange test. r=jaws,MattN
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•