1471274 - Inner text should not affect the behaviour of size-contained elements

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Morgan Reschenberg [:morgan]]

According to the draft spec for containment [1], "When laying out the containing element, it must be treated as having no contents. After layout of the element is complete, its contents must then be laid out into the containing element’s resolved size". 

The current implementation for 'contain:size' behaves correctly on most frame types, however in flexContinerFrames and HTMLButtonControlFrames information about text contents leaks and affects the positioning/margins of size-contained elements in a small subset of cases. 

[1] https://drafts.csswg.org/css-contain/#containment-size

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: contain-size-flex-002-ref.html

Test case for currently failing 'contain:size' case on flexContainerFrame

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: contain-size-flex-002-ref.html

Reference case for currently failing 'contain:size' case on flexContainerFrame

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: contain-size-flex-002.html

Test case for currently failing 'contain:size' case on flexContainerFrame

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: contain-size-button-002-ref.html

Reference case for currently failing 'contain:size' case on HTMLButtonControlFrame

Comment 5

[Morgan Reschenberg [:morgan]]

Attachment: contain-size-button-002.html

Test case for currently failing 'contain:size' case on HTMLButtonControlFrame

Comment 6

[Morgan Reschenberg [:morgan]]

Fixed in main implementation (Bug 1467209)