1471289 - Allow creation of WebAssembly.Global with type i64 if initial value is omitted in constructor call

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

Spec tweak from the CG meeting 2018-06-26: we should allow this to work (also for mutable globals):

  new WebAssembly.Global({value: 'i64'})

with the default value 0.  This just reduces annoyance.  We can already create such a global by creating it in wasm and exporting it.  For nonzero values we'll still have to do that.

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1471289-default-i64-wasm-global.patch

Comment 2

[Julian Seward [:jseward]]

Comment on attachment 8988422 [details] [diff] [review]
bug1471289-default-i64-wasm-global.patch

Looks fine to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2f1f75b9134
Handle 'new WebAssembly.Global' on i64 with default value. r=jseward

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f2f1f75b9134 (bug 1471289) for spidermonkey bustages on wasm-testharness.js:31:15

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf241677f19357807b6fbb1a4a23f1a36b649c3e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f2f1f75b91343ccfc0b298a5cc634c487202148f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&selectedJob=185466574

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185466574&repo=mozilla-inbound&lineNumber=88236

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c3c2d6c17d7
Handle 'new WebAssembly.Global' on i64 with default value. r=jseward

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7c3c2d6c17d7