Closed Bug 1471293 Opened 3 years ago Closed 3 years ago

Support using llvm-objdump in dependentlibs.py

Categories

(Firefox Build System :: General, enhancement)

60 Branch
enhancement
Not set
normal

Tracking

(firefox-esr60 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently support dumpbin and objdump for Windows target, but toolchain we intend to use in bug 1465790 doesn't have neither. It does have its llvm replacement, llvm-objdump.
Comment on attachment 8987898 [details]
Bug 1471293 - Support using llvm-objdump in dependentlibs.py

https://reviewboard.mozilla.org/r/253186/#review259902
Attachment #8987898 - Flags: review?(mh+mozilla) → review+
Pushed by jacek@codeweavers.com:
https://hg.mozilla.org/integration/autoland/rev/e922b59832f1
Support using llvm-objdump in dependentlibs.py r=glandium
Comment on attachment 8987898 [details]
Bug 1471293 - Support using llvm-objdump in dependentlibs.py

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit only affects the MinGW build, so it is low risk.
Attachment #8987898 - Flags: approval-mozilla-esr60?
https://hg.mozilla.org/mozilla-central/rev/e922b59832f1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment on attachment 8987898 [details]
Bug 1471293 - Support using llvm-objdump in dependentlibs.py

Makes downstream maintenance easier for Tor. Approved for ESR 60.2.
Attachment #8987898 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.