Closed Bug 1471303 Opened Last year Closed Last year

Fix CopyableErrorResult copy constructor and assignment operator constness

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

In bug 1357463 I added CopyableErrorResult to support copying as part of ipdl structures.  I botched the copy constructor and assignment operator method signatures, though.  They need to be const.

Splitting this patch out from bug 1459209.
Err, this is about const operator==() actually.  Sorry for wrong description in comment 0.
Comment on attachment 8987904 [details] [diff] [review]
Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz

Boris, this patch fixes a few things I missed in bug 1357463.  Specifically:

1. The Message and DOMException structures need to have const operator==().
2. TErrorResult<>::operator==() needs to be able to access the Message and DOMException operator==() implementation.  So it needs to move into BindingUtils.cpp.

With these changes CopyableErrorResult compiles in ipdl structures correctly.
Attachment #8987904 - Flags: review?(bzbarsky)
Comment on attachment 8987904 [details] [diff] [review]
Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz

r=me
Attachment #8987904 - Flags: review?(bzbarsky) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0be300394024
Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz
https://hg.mozilla.org/mozilla-central/rev/0be300394024
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.