1471341 - Warn user when viewing a revision that they have admin rights and their account is not linked to BMO

Status: NEW

(Conduit :: Phabricator, enhancement, P3)

Description

[David Lawrence [:dkl]]

This only matters really for revisions with bug id links, but we want to discourage revision changes from a user account that has admin rights and/or does not have a link to a valid BMO account. This causes issues with the Phabbugz daemon in BMO when it see changes made by users who do not have related BMO accounts.

dkl

Comment 1

[:glob ✱]

this shouldn't be a warning - we should outright prevent admin users from conducting reviews.

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to Byron Jones ‹:glob› from comment #1)
> this shouldn't be a warning - we should outright prevent admin users from
> conducting reviews.

This seems a little overkill to me, there are a limited number of admins that should just not do it IMO. Spending time modifying Phabricator to make it impossible sounds fragile and not really worth it.

Comment 3

[David Lawrence [:dkl]]

In an attempt to get my work load down to a manageable amount, I am un-assigning some bugs from my list. In the future when I assign a bug to myself, it will mean I am actively working on it and has become a priority. This action doesn't mean you bug will not be addressed, but will reassessed as time allows. Please comment if this is not acceptable. Thanks.