1471371 - Missing OOM handling in js::ParseRegExpFlags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

Missing OOM handling here [1]. I'm not sure why we don't simply pass |cx| to JS::CharsToNewUTF8CharsZ to properly propagate the OOM error?

[1] https://searchfox.org/mozilla-central/rev/14cb8f1c238735ba1abe18ad44e39808983c2572/js/src/vm/RegExpObject.cpp#1424-1426


Test case:
---
oomTest(function() {
    for (var i = 0; i < 10; ++i) {
        try {
            RegExp("", "gimuyz");
        } catch {}
    }
});
---

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: OOM handling in RegExp construction

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8999973 [details] [diff] [review]
OOM handling in RegExp construction

Review of attachment 8999973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Thanks!

Comment 3

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb5658c1ec29dc0e95ae24c427658baf742bd3a7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e58207e220a
Add OOM handling in RegExp construction. r=jorendorff

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for spidermonkey failures at oom-in-construction.js

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/083414a62ea15be84270efc2bc86bb358a3b22f1

push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7e58207e220a837a79af6101c6fdfb14bb84a828

failure log: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7e58207e220a837a79af6101c6fdfb14bb84a828

task 2018-08-15T21:00:57.371Z] TEST-PASS | non262/RegExp/regress-334158.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.0 s]
[task 2018-08-15T21:00:57.371Z] {"action": "test_start", "jitflags": [], "pid": 50365, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "non262/RegExp/regress-334158.js", "thread": "main", "time": 1534366857.330933}
[task 2018-08-15T21:00:57.371Z] {"action": "test_end", "extra": {"jitflags": [], "pid": 50365, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 50365, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "PASS", "test": "non262/RegExp/regress-334158.js", "thread": "main", "time": 1534366857.371726}
[task 2018-08-15T21:00:57.383Z] ## non262/RegExp/oom-in-construction.js: rc = 0, run time = 0.050823
[task 2018-08-15T21:00:57.383Z] BUGNUMBER: 1471371
[task 2018-08-15T21:00:57.383Z] STATUS: Handle OOM in RegExp
[task 2018-08-15T21:00:57.383Z] TEST-UNEXPECTED-FAIL | non262/RegExp/oom-in-construction.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.1 s]
[task 2018-08-15T21:00:57.383Z] {"action": "test_start", "jitflags": [], "pid": 50398, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "non262/RegExp/oom-in-construction.js", "thread": "main", "time": 1534366857.332639}
[task 2018-08-15T21:00:57.383Z] {"action": "test_end", "extra": {"jitflags": [], "pid": 50398, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 50398, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "FAIL", "test": "non262/RegExp/oom-in-construction.js", "thread": "main", "time": 1534366857.383462}
[task 2018-08-15T21:00:57.384Z] TEST-PASS | non262/RegExp/RegExp_leftContext_as_array.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.0 s]
[task 2018-08-15T21:00:57.384Z] {"action": "test_start", "jitflags": [], "pid": 50403, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "non262/RegExp/RegExp_leftContext_as_array.js", "thread": "main", "time": 1534366857.3369}
[task 2018-08-15T21:00:57.384Z] {"action": "test_end", "extra": {"jitflags": [], "pid": 50403, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 50403, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "PASS", "test": "non262/RegExp/RegExp_leftContext_as_array.js", "thread": "main", "time": 1534366857.384053}
[task 2018-08-15T21:00:57.384Z] TEST-PASS | non262/RegExp/regress-165353.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.0 s]

Comment 6

[Ashley Hauck [:khyperia]]

Attachment: OOM handling in RegExp construction

Comment 7

[Ashley Hauck [:khyperia]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff7df5fdef1fea1ac4727609010c4c62eb3a0e61

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8464c338715d
OOM handling in RegExp construction. r=jorendorff

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8464c338715d