1471372 - Add some telemetry about TextureClientPool and tile allocation

Status: RESOLVED WONTFIX

(Core :: Graphics: Layers, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

I've seen it mentioned in a couple profiles/bugs that we have poor allocation behaviour with our tile pool. One example is bug 1421638. I think it could be worth adding some telemetry probes to get some more information here.

I think two things are worth knowing:

1. The cost of allocating a tile in time (we already have a good idea on the memory cost from the tile size)
2. The 'average' or 'max' amount of tiles needed over some time period

For #2, I've experimented with tracking the maximum outstanding texture clients in the periods between when we clear all unused texture clients. We currently clear out all unused texture clients about 5 seconds after texture client pool inactivity. I chose this because I think it corresponds with 'activity' but it's arbitrary.

Comment 1

[Ryan Hunt [:rhunt]]

Nical, do you have any thoughts here on things we could improve and what information we'd need to guide it?

Comment 2

[Ryan Hunt [:rhunt]]

From an irc conversation with Nical I think I have some ideas of where to go.

Comment 3

[Ryan Hunt [:rhunt]]

It looks like bug 1477148 could improve our situation here, and I don't have any immediate plans to do this so I will close this.