Closed Bug 1471386 Opened 7 years ago Closed 7 years ago

Use the rust-1.28 toolchain for the Tup build

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: chmanchester, Unassigned)

References

Details

The linux64-rust-nightly job can be removed as well. This should have happened in bug 1447116.
(In reply to Chris Manchester (:chmanchester) from comment #0) > The linux64-rust-nightly job can be removed as well. Probably not. The nightly jobs are used by code coverage, and I think they need it for unstable features.
(In reply to Mike Hommey [:glandium] from comment #1) > (In reply to Chris Manchester (:chmanchester) from comment #0) > > The linux64-rust-nightly job can be removed as well. > > Probably not. The nightly jobs are used by code coverage, and I think they > need it for unstable features. Yes, I filed bug 1473069 about that. I think we can switch to stable when 1.28 is out (and we can enable the unstable features with RUSTC_BOOTSTRAP, right?)
(In reply to Marco Castelluccio [:marco] from comment #2) > (In reply to Mike Hommey [:glandium] from comment #1) > > (In reply to Chris Manchester (:chmanchester) from comment #0) > > > The linux64-rust-nightly job can be removed as well. > > > > Probably not. The nightly jobs are used by code coverage, and I think they > > need it for unstable features. > > Yes, I filed bug 1473069 about that. I think we can switch to stable when > 1.28 is out (and we can enable the unstable features with RUSTC_BOOTSTRAP, > right?) Is the 1.28 beta we're using to build central right now recent enough?
Flags: needinfo?(mcastelluccio)
(In reply to Chris Manchester (:chmanchester) from comment #3) > (In reply to Marco Castelluccio [:marco] from comment #2) > > (In reply to Mike Hommey [:glandium] from comment #1) > > > (In reply to Chris Manchester (:chmanchester) from comment #0) > > > > The linux64-rust-nightly job can be removed as well. > > > > > > Probably not. The nightly jobs are used by code coverage, and I think they > > > need it for unstable features. > > > > Yes, I filed bug 1473069 about that. I think we can switch to stable when > > 1.28 is out (and we can enable the unstable features with RUSTC_BOOTSTRAP, > > right?) > > Is the 1.28 beta we're using to build central right now recent enough? It might be, but there could be other fixes landing for gcov coverage soon, so I'd rather keep using the nightly build for the time being.
Flags: needinfo?(mcastelluccio)
I was wrong about this, we need to be on the nightly channel to use unstable cargo features (build-plan is needed for the tup build).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.