Closed Bug 1471435 Opened 2 years ago Closed 2 years ago

small cleanups in nsFileStreams.cpp

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

I know this is networking code, but it really feels like XPCOM code.
We should be using smart pointers here, and there's no need to check for
allocation failure with our infallible new policy.
Attachment #8988027 - Flags: review?(valentin.gosu)
We shouldn't need to QueryInterface from nsIFile to nsIFile!
Attachment #8988028 - Flags: review?(valentin.gosu)
Attachment #8988027 - Flags: review?(valentin.gosu) → review+
Attachment #8988028 - Flags: review?(valentin.gosu) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14b77f98e81c
part 1 - clean up nsFile{Input,Ouput}Stream::Create; r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0b7524a7081
part 2 - micro-optimize deferred MaybeOpen calls; r=valentin
https://hg.mozilla.org/mozilla-central/rev/14b77f98e81c
https://hg.mozilla.org/mozilla-central/rev/f0b7524a7081
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.