Have mach detect rustfmt and use that for bindgen

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
I think there is a value to have rustfmt run automatically in local build as well.
Comment hidden (mozreview-request)
(Assignee)

Updated

11 months ago
Attachment #8988074 - Flags: review?(core-build-config-reviews)

Comment 3

11 months ago
mozreview-review
Comment on attachment 8988075 [details]
Bug 1471486 part 2 - Use RUSTFMT env in stylo build script.

https://reviewboard.mozilla.org/r/253330/#review259964

Code-wise looks good, but note that glandium asked for it to be optional in https://bugzilla.mozilla.org/show_bug.cgi?id=1432153#c4 explicitly. So you may want to check with him or what not.
Attachment #8988075 - Flags: review?(emilio) → review+
Attachment #8988074 - Flags: review?(core-build-config-reviews) → review?(nfroyd)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8988074 [details]
Bug 1471486 part 1 - Detect rustfmt like other rust executables.

https://reviewboard.mozilla.org/r/253328/#review260006
Attachment #8988074 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 5

11 months ago
glandium, since emilio said you asked running rustfmt on generated files to be optional in bug 1432153 comment 4, what do you think about this?

This is still optional, via explicitly clearing RUSTFMT in mozconfig, or just remove rustfmt command from PATH. Do you think it's enough for what you were concerned in bug 1432153 comment 4?
Flags: needinfo?(mh+mozilla)
Yes. That's what I meant by optional.
Flags: needinfo?(mh+mozilla)
(Assignee)

Comment 7

11 months ago
OK, thanks!

Comment 8

11 months ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/799ee5183d48
part 1 - Detect rustfmt like other rust executables. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/765b972ec1c1
part 2 - Use RUSTFMT env in stylo build script. r=emilio

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/799ee5183d48
https://hg.mozilla.org/mozilla-central/rev/765b972ec1c1
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.