Closed Bug 1471542 Opened 5 years ago Closed 5 years ago

Remove support for tree[seltype="cell"] and tree[seltype="text"]

Categories

(Toolkit :: XUL Widgets, task, P5)

Product:
Toolkit
Component:
XUL Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [ntim-intern-project])

Attachments

(1 file)

Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].
59 bytes, text/x-review-board-request
Paolo
: review+
Details 
It's mostly unused in mozilla-central and comm-central (only one usage for SeaMonkey), and it simplifies the tree styling.
Blocks: 1446335
Assignee: nobody → ntim.bugs
Blocks: 1469287
Blocks: war-on-xbl
Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

https://reviewboard.mozilla.org/r/253384/#review260096

Thanks, this definitely allow us to remove many unused styles.
Attachment #8988134 - Flags: review?(paolo.mozmail) → review+
Heads up that we're removing this. The only use I see in comm-central is for the "Folder Location" dropdown, which is in the customization palette by default, and I'm not even sure why this "seltype" is necessary there.
Blocks: 1446341
Flags: needinfo?(richard.marti)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6a6418171cee
Remove support for tree[seltype=cell] and tree[seltype=text]. r=Paolo
Thank you, Paolo for the heads up. Tim already informed me on IRC. The remaining seltype="text" is in suite and SM is unfortunately broken since longer time and need a lot of work. And this one is probably one of the simpler thing to fix for them.
Flags: needinfo?(richard.marti)
Priority: -- → P5
Whiteboard: [ntim-intern-project]
https://hg.mozilla.org/mozilla-central/rev/6a6418171cee
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1508142
Type: enhancement → task
See Also: → 1806653
You need to log in before you can comment on or make changes to this bug.