1471542 - Remove support for tree[seltype="cell"] and tree[seltype="text"]

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Tim Nguyen :ntim]

It's mostly unused in mozilla-central and comm-central (only one usage for SeaMonkey), and it simplifies the tree styling.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

Review commit: https://reviewboard.mozilla.org/r/253384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253384/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253384/diff/1-2/

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253384/diff/2-3/

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253384/diff/3-4/

Comment 5

[:Paolo Amadini]

Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

https://reviewboard.mozilla.org/r/253384/#review260096

Thanks, this definitely allow us to remove many unused styles.

Comment 6

[:Paolo Amadini]

Heads up that we're removing this. The only use I see in comm-central is for the "Folder Location" dropdown, which is in the customization palette by default, and I'm not even sure why this "seltype" is necessary there.

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253384/diff/4-5/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a6418171cee
Remove support for tree[seltype=cell] and tree[seltype=text]. r=Paolo

Comment 9

[Richard Marti (:Paenglab)]

Thank you, Paolo for the heads up. Tim already informed me on IRC. The remaining seltype="text" is in suite and SM is unfortunately broken since longer time and need a lot of work. And this one is probably one of the simpler thing to fix for them.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6a6418171cee