Remove support for tree[seltype="cell"] and tree[seltype="text"]

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P5
normal
RESOLVED FIXED
10 months ago
5 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks 3 bugs)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [ntim-intern-project])

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
It's mostly unused in mozilla-central and comm-central (only one usage for SeaMonkey), and it simplifies the tree styling.
(Assignee)

Updated

10 months ago
Blocks: 1446335
(Assignee)

Updated

10 months ago
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Blocks: 1469287
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Blocks: war-on-xbl

Comment 5

10 months ago
mozreview-review
Comment on attachment 8988134 [details]
Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text].

https://reviewboard.mozilla.org/r/253384/#review260096

Thanks, this definitely allow us to remove many unused styles.
Attachment #8988134 - Flags: review?(paolo.mozmail) → review+

Comment 6

10 months ago
Heads up that we're removing this. The only use I see in comm-central is for the "Folder Location" dropdown, which is in the customization palette by default, and I'm not even sure why this "seltype" is necessary there.
Blocks: 1446341
Flags: needinfo?(richard.marti)
Comment hidden (mozreview-request)

Comment 8

10 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6a6418171cee
Remove support for tree[seltype=cell] and tree[seltype=text]. r=Paolo
Thank you, Paolo for the heads up. Tim already informed me on IRC. The remaining seltype="text" is in suite and SM is unfortunately broken since longer time and need a lot of work. And this one is probably one of the simpler thing to fix for them.
Flags: needinfo?(richard.marti)

Updated

10 months ago
Priority: -- → P5
(Assignee)

Updated

10 months ago
Whiteboard: [ntim-intern-project]

Comment 10

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6a6418171cee
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(Assignee)

Updated

5 months ago
Depends on: 1508142
You need to log in before you can comment on or make changes to this bug.