Closed Bug 1471566 Opened 6 years ago Closed 6 years ago

Fix oss-fuzz build

Categories

(NSS :: Build, enhancement, P3)

3.38
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: franziskus, Assigned: franziskus)

References

()

Details

Attachments

(1 file)

The oss-fuzz NSS build currently fails with errors such as

Step #4: /tmp/mpprime-d17eb8.s: Assembler messages:
Step #4: /tmp/mpprime-d17eb8.s:10223: Fatal error: bad .section directive: want a,l,w,x,M,S,G,T in string
This was a bad LLVM version.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
There was more to this.
Assignee: nobody → franziskuskiefer
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
https://hg.mozilla.org/projects/nss/rev/77ae602f995a9e31e19a4e28426dce7a21ff0b56
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
This doesn't build with gecko in several ways:

1. https://taskcluster-artifacts.net/EmD_oH0PRNWoc0fWrdfSVQ/0/public/logs/live_backing.log

[task 2018-10-16T03:33:23.515Z] 03:33:23     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/gcc -std=gnu99 -o intel-aes.o -fPIC -Wa,--noexecstack -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -g -no-integrated-as '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DHAVE_INT128_SUPPORT -DFREEBL_LOWHASH -DFREEBL_NO_DEPEND -DMP_IS_LITTLE_ENDIAN -DNSS_BEVAND_ARCFOUR -DMPI_AMD64 -DMP_ASSEMBLY_MULTIPLY -DNSS_USE_COMBA -DUSE_HW_AES -DINTEL_GCM -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_LIBPKIX -DNDEBUG  -c /builds/worker/workspace/build/src/security/nss/lib/freebl/intel-aes.s
[task 2018-10-16T03:33:23.515Z] 03:33:23     INFO -  gcc: error: unrecognized command line option '-no-integrated-as'; did you mean '-no-integrated-cpp'?
[task 2018-10-16T03:33:23.515Z] 03:33:23     INFO -  /builds/worker/workspace/build/src/config/rules.mk:798: recipe for target 'intel-aes.o' failed
[task 2018-10-16T03:33:23.515Z] 03:33:23     INFO -  make[4]: *** [intel-aes.o] Error 1


2. https://taskcluster-artifacts.net/PWYKeygGQkWVwERA61Hqtg/0/public/logs/live_backing.log

[task 2018-10-16T03:41:06.018Z] 03:41:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3'
[task 2018-10-16T03:41:06.035Z] 03:41:06     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang -std=gnu99 --target=x86_64-linux-android -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=21 -fno-short-enums -fno-exceptions -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pipe -g -Oz -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments  -fPIC -shared -Wl,-z,defs -Wl,--gc-sections -Wl,-h,libfreebl3.so -o libfreebl3.so /builds/worker/workspace/build/src/obj-firefox/security/nss/lib/freebl/freebl_freebl3/libfreebl3_so.list  -flto=thin -L/builds/worker/workspace/build/src/android-ndk/platforms/android-21/arch-x86_64/usr/lib -Wl,-rpath-link=/builds/worker/workspace/build/src/android-ndk/platforms/android-21/arch-x86_64/usr/lib --sysroot=/builds/worker/workspace/build/src/android-ndk/platforms/android-21/arch-x86_64 -Wl,--allow-shlib-undefined -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-z,nocopyreloc -Wl,--build-id=sha1 -Wl,--icf=safe -Wl,--hash-style=sysv -Wl,-rpath-link,/builds/worker/workspace/build/src/obj-firefox/dist/bin -Wl,-rpath-link,/usr/local/lib -O2     ../../../../libnss3.so -Wl,--version-script,out.freebl.def
[task 2018-10-16T03:41:06.035Z] 03:41:06     INFO -  /builds/worker/workspace/build/src/security/nss/lib/freebl/rijndael.c:0: error: undefined reference to 'intel_aes_encrypt_cbc_128'
[task 2018-10-16T03:41:06.035Z] 03:41:06     INFO -  /builds/worker/workspace/build/src/security/nss/lib/freebl/rijndael.c:0: error: undefined reference to 'intel_aes_encrypt_ecb_128'

I'm going to back this one out and we can reassess.  I think that any patch for this needs to include a full gecko build on try.  My partial try run missed this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5545ee1314f68f74ad993df2cedde187255a1d0 shows that the first problem is fixed by moving the -no-integrated-as arguments, but the second remains.  It looks like there is a missing dependency on the new static library there.
This includes fixes that broke the Firefox build.
fixed in https://hg.mozilla.org/projects/nss/rev/f116b154e061d6c7af03cbba38579b6fc3499fdf
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.41
You need to log in before you can comment on or make changes to this bug.