Closed Bug 1471607 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11688 - [LayoutNG] Allow epsilon when fitting into a line

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11688 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11688
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:
>  [LayoutNG] Allow epsilon when fitting into a line
>  
>  When NGLineBreaker tries to fit items into a line, rounding
>  errors are hard to avoid. One case is to fit `monospace` font
>  into a container whose `width` is set by `ch` unit.
>  
>  Blink computes `ch` units in float, then round to LayoutUnit.
>  This rounding often prevents the specified number of
>  characters to fit into the line. All 4 impls pass this test
>  for `3ch` to `100ch`.
>  
>  Bug: 636993
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: I9fe68a8bb44820aa15c7eb8c564776688c8320ee
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1116409
>  WPT-Export-Revision: a289c447c039a021ab048e32cb9765cbcbcf86f8
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 194 subtests
OK     : 1
PASS   : 194
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fec2e1e5e67
[wpt PR 11688] - [LayoutNG] Allow epsilon when fitting into a line, a=testonly
https://hg.mozilla.org/mozilla-central/rev/5fec2e1e5e67
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.