1471614 - remove some dead code in CycleCollectedJSRuntime

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nathan Froyd [:froydnj]]

Not only is it dead code, but it's a significant amount of useless work!

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: remove some dead code in CycleCollectedJSRuntime

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8988187 [details] [diff] [review]
remove some dead code in CycleCollectedJSRuntime

Review of attachment 8988187 [details] [diff] [review]:
-----------------------------------------------------------------

Weird.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca9cade7725
remove some dead code in CycleCollectedJSRuntime; r=mccr8

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 0ca9cade7725 (bug 1471614) for XPCshell failures on devtools/shared/tests/unit/test_css-properties-db.js

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=185188242&repo=mozilla-inbound&lineNumber=2037

TEST-START | devtools/shared/tests/unit/test_css-properties-db.js
[task 2018-06-27T15:38:17.735Z] 15:38:17  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | xpcshell return code: 0
[task 2018-06-27T15:38:17.735Z] 15:38:17     INFO -  TEST-INFO took 557ms
[task 2018-06-27T15:38:17.736Z] 15:38:17     INFO -  >>>>>>>
[task 2018-06-27T15:38:17.737Z] 15:38:17     INFO -  PID 8982 | JavaScript strict warning: resource://devtools/shared/Loader.jsm, line 224: ReferenceError: reference to undefined property "name"
[task 2018-06-27T15:38:17.737Z] 15:38:17     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2018-06-27T15:38:17.738Z] 15:38:17     INFO -  TEST-PASS | devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 35] The pseudo elements match on the client and platform. If this assertion fails, then the client side CSS properties list in devtools is out of sync with the CSS properties on the platform. To fix this assertion run `mach devtools-css-db` to re-generate the client side properties. - [":after",":before",":backdrop",":cue",":first-letter",":first-line",":selection",":-moz-focus-inner",":-moz-focus-outer",":-moz-list-bullet",":-moz-list-number",":-moz-progress-bar",":-moz-range-track",":-moz-range-progress",":-moz-range-thumb",":-moz-meter-bar",":-moz-placeholder",":placeholder",":-moz-color-swatch"] deepEqual [":after",":before",":backdrop",":cue",":first-letter",":first-line",":selection",":-moz-focus-inner",":-moz-focus-outer",":-moz-list-bullet",":-moz-list-number",":-moz-progress-bar",":-moz-range-track",":-moz-range-progress",":-moz-range-thumb",":-moz-meter-bar",":-moz-placeholder",":placeholder",":-moz-color-swatch"]
[task 2018-06-27T15:38:17.757Z] 15:38:17  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 40] The preferences match on the client and platform. If this assertion fails, then the client side CSS properties list in devtools is out of sync with the CSS properties on the platform. To fix this assertion run `mach devtools-css-db` to re-generate the client side properties. - [["background-blend-mode","layout.css.background-blend-mode.enabled"],["box-decoration-break","layout.css.box-decoration-break.enabled"],["color-adjust","layout.css.color-adjust.enabled"],["column-span","layout.css.column-span.enabled"],["contain","layout.css.contain.enabled"],["font-optical-sizing","layout.css.font-variations.enabled"],["font-variation-settings","layout.css.font-variations.enabled"],["image-orientation","layout.css.image-orientation.enabled"],["initial-letter","layout.css.initial-letter.enabled"],["isolation","layout.css.isolation.enabled"],["mix-blend-mode","layout.css.mix-blend-mode.enabled"],["-moz-osx-font-smoothing","layout.css.osx-font-smoothing.enabled"],["overflow-clip-box-block","layout.css.overflow-clip-box.enabled"],["overflow-clip-box-inline","layout.css.overflow-clip-box.enabled"],["overscroll-behavior-x","layout.css.overscroll-behavior.enabled"],["overscroll-behavior-y","layout.css.overscroll-behavior.enabled"],["rotate","layout.css.individual-transform.enabled"],["scale","layout.css.individual-transform.enabled"],["scroll-behavior","layout.css.scroll-behavior.property-enabled"],["scroll-snap-coordinate","layout.css.scroll-snap.enabled"],["scroll-snap-destination","layout.css.scroll-snap.enabled"],["scroll-snap-points-x","layout.css.scroll-snap.enabled"],["scroll-snap-points-y","layout.css.scroll-snap.enabled"],["scroll-snap-type-x","layout.css.scroll-snap.enabled"],["scroll-snap-type-y","layout.css.scroll-snap.enabled"],["scrollbar-face-color","layout.css.scrollbar-colors.enabled"],["scrollbar-track-color","layout.css.scrollbar-colors.enabled"],["shape-image-threshold","layout.css.shape-outside.enabled"],["shape-margin","layout.css.shape-outside.enabled"],["shape-outside","layout.css.shape-outside.enabled"],["-webkit-text-fill-color","layout.css.prefixes.webkit"],["text-justify","layout.css.text-justify.enabled"],["-webkit-text-stroke-color","layout.css.prefixes.webkit"],["-webkit-text-stroke-width","layout.css.prefixes.webkit"],["touch-action","layout.css.touch_action.enabled"],["transform-box","svg.transform-box.enabled"],["translate","layout.css.individual-transform.enabled"],["all","layout.css.all-shorthand.enabled"],["overflow-clip-box","layout.css.overflow-clip-box.enabled"],["overscroll-behavior","layout.css.overscroll-behavior.enabled"],["scroll-snap-type","layout.css.scroll-snap.enabled"],["-webkit-text-stroke","layout.css.prefixes.webkit"],["-moz-animation","layout.css.prefixes.animations"],["-moz-animation-delay","layout.css.prefixes.animations"],["-moz-animation-direction","layout.css.prefixes.animations"],["-moz-animation-duration","layout.css.prefixes.animations"],["-moz-animation-fill-mode","layout.css.prefixes.animations"],["-moz-animation-iteration-count","layout.css.prefixes.animations"],["-moz-animation-name","layout.css.prefixes.animations"],["-moz-animation-play-state","layout.css.prefixes.animations"],["-moz-animation-timing-function","layout.css.prefixes.animations"],["-moz-backface-visibility","layout.css.prefixes.transforms"],["-moz-border-image","layout.css.prefixes.border-image"],["-moz-box-sizing","layout.css.prefixes.box-sizing"],["-moz-column-span","layout.css.column-span.enabled"],["-moz-font-feature-settings","layout.css.prefixes.font-features"],["-moz-font-language-override","layout.css.prefixes.font-features"],["-moz-perspective","layout.css.prefixes.transforms"],["-moz-perspective-origin","layout.css.prefixes.transforms"],["-moz-transform","layout.css.prefixes.transforms"],["-moz-transform-origin","layout.css.prefixes.transforms"],["-moz-transform-style","layout.css.prefixes.transforms"],["-moz-transition","layout.css.prefixes.transitions"],["-moz-transition-delay","layout.css.prefixes.transitions"],["-moz-transition-duration","layout.css.prefixes.transitions"],["-moz-transition-property","layout.css.prefixes.transitions"],["-moz-transition-timing-function","layout.css.prefixes.transitions"],["-webkit-align-content","layout.css.prefixes.webkit"],["-webkit-align-items","layout.css.prefixes.webkit"],["-webkit-align-self","layout.css.prefixes.webkit"],["-webkit-animation","layout.css.prefixes.webkit"],["-webkit-animation-delay","layout.css.prefixes.webkit"],["-webkit-animation-direction","layout.css.prefixes.webkit"],["-webkit-animation-duration","layout.css.prefixes.webkit"],["-webkit-animation-fill-mode","layout.css.prefixes.webkit"],["-webkit-animation-iteration-count","layout.css.prefixes.webkit"],["-webkit-animation-name","layout.css.prefixes.webkit"],["-webkit-animation-play-state","layout.css.prefixes.webkit"],["-webkit-animation-timing-function","layout.css.prefixes.webkit"],["-webkit-appearance","layout.css.webkit-appearance.enabled"],["-webkit-backface-visibility","layout.css.prefixes.webkit"],["-webkit-background-clip","layout.css.prefixes.webkit"],["-webkit-background-origin","layout.css.prefixes.webkit"],["-webkit-background-size","layout.css.prefixes.webkit"],["-webkit-border-bottom-left-radius","layout.css.prefixes.webkit"],["-webkit-border-bottom-right-radius","layout.css.prefixes.webkit"],["-webkit-border-image","layout.css.prefixes.webkit"],["-webkit-border-radius","layout.css.prefixes.webkit"],["-webkit-border-top-left-radius","layout.css.prefixes.webkit"],["-webkit-border-top-right-radius","layout.css.prefixes.webkit"],["-webkit-box-align","layout.css.prefixes.webkit"],["-webkit-box-direction","layout.css.prefixes.webkit"],["-webkit-box-flex","layout.css.prefixes.webkit"],["-webkit-box-ordinal-group","layout.css.prefixes.webkit"],["-webkit-box-orient","layout.css.prefixes.webkit"],["-webkit-box-pack","layout.css.prefixes.webkit"],["-webkit-box-shadow","layout.css.prefixes.webkit"],["-webkit-box-sizing","layout.css.prefixes.webkit"],["-webkit-filter","layout.css.prefixes.webkit"],["-webkit-flex","layout.css.prefixes.webkit"],["-webkit-flex-basis","layout.css.prefixes.webkit"],["-webkit-flex-direction","layout.css.prefixes.webkit"],["-webkit-flex-flow","layout.css.prefixes.webkit"],["-webkit-flex-grow","layout.css.prefixes.webkit"],["-webkit-flex-shrink","layout.css.prefixes.webkit"],["-webkit-flex-wrap","layout.css.prefixes.webkit"],["-webkit-justify-content","layout.css.prefixes.webkit"],["-webkit-mask","layout.css.prefixes.webkit"],["-webkit-mask-clip","layout.css.prefixes.webkit"],["-webkit-mask-composite","layout.css.prefixes.webkit"],["-webkit-mask-image","layout.css.prefixes.webkit"],["-webkit-mask-origin","layout.css.prefixes.webkit"],["-webkit-mask-position","layout.css.prefixes.webkit"],["-webkit-mask-position-x","layout.css.prefixes.webkit"],["-webkit-mask-position-y","layout.css.prefixes.webkit"],["-webkit-mask-repeat","layout.css.prefixes.webkit"],["-webkit-mask-size","layout.css.prefixes.webkit"],["-webkit-order","layout.css.prefixes.webkit"],["-webkit-perspective","layout.css.prefixes.webkit"],["-webkit-perspective-origin","layout.css.prefixes.webkit"],["-webkit-text-size-adjust","layout.css.prefixes.webkit"],["-webkit-transform","layout.css.prefixes.webkit"],["-webkit-transform-origin","layout.css.prefixes.webkit"],["-webkit-transform-style","layout.css.prefixes.webkit"],["-webkit-transition","layout.css.prefixes.webkit"],["-webkit-transition-delay","layout.css.prefixes.webkit"],["-webkit-transition-duration","layout.css.prefixes.webkit"],["-webkit-transition-property","layout.css.prefixes.webkit"],["-webkit-transition-timing-function","layout.css.prefixes.webkit"],["-webkit-user-select","layout.css.prefixes.webkit"]] deepEqual [["background-blend-mode","layout.css.background-blend-mode.enabled"],["box-decoration-break","layout.css.box-decoration-break.enabled"],["color-adjust","layout.css.color-adjust.enabled"],["column-span","layout.css.column-span.enabled"],["contain","layout.css.contain.enabled"],["font-optical-sizing","layout.css.font-variations.enabled"],["font-variation-settings","layout.css.font-variations.enabled"],["image-orientation","layout.css.image-orientation.enabled"],["initial-letter","layout.css.initial-letter.enabled"],["isolation","layout.css.isolation.enabled"],["mix-blend-mode","layout.css.mix-blend-mode.enabled"],["-moz-osx-font-smoothing","layout.css.osx-font-smoothing.enabled"],["overflow-clip-box-block","layout.css.overflow-clip-box.enabled"],["overflow-clip-box-inline","layout.css.overflow-clip-box.enabled"],["overscroll-behavior-x","layout.css.overscroll-behavior.enabled"],["overscroll-behavior-y","layout.css.overscroll-behavior.enabled"],["rotate","layout.css.individual-transform.enabled"],["scale","layout.css.individual-transform.enabled"],["scroll-behavior","layout.css.scroll-behavior.property-enabled"],["scroll-snap-coordinate","layout.css.scroll-snap.enabled"],["scroll-snap-destination","layout.css.scroll-snap.enabled"],["scroll-snap-points-x","layout.css.scroll-snap.enabled"],["scroll-snap-points-y","layout.css.scroll-snap.enabled"],["scroll-snap-type-x","layout.css.scroll-snap.enabled"],["scroll-snap-type-y","layout.css.scroll-snap.enabled"],["scrollbar-face-color","layout.css.scrollbar-colors.enabled"],["scrollbar-track-color","layout.css.scrollbar-colors.enabled"],["shape-image-threshold","layout.css.shape-outside.enabled"],["shape-margin","layout.css.shape-outside.enabled"],["shape-outside","layout.css.shape-outside.enabled"],["-webkit-text-fill-color","layout.css.prefixes.webkit"],["text-justify","layout.css.text-justify.enabled"],["-webkit-text-stroke-color","layout.css.prefixes.webkit"],["-webkit-text-stroke-width","layout.css.prefixes.webkit"],["touch-action","layout.css.touch_action.enabled"],["transform-box","svg.transform-box.enabled"],["translate","layout.css.individual-transform.enabled"],["all","layout.css.all-shorthand.enabled"],["overflow-clip-box","layout.css.overflow-clip-box.enabled"],["overscroll-behavior","layout.css.overscroll-behavior.enabled"],["scroll-snap-type","layout.css.scroll-snap.enabled"],["-webkit-text-stroke","layout.css.prefixes.webkit"],["-moz-animation","layout.css.prefixes.animations"],["-moz-animation-delay","layout.css.prefixes.animations"],["-moz-animation-direction","layout.css.prefixes.animations"],["-moz-animation-duration","layout.css.prefixes.animations"],["-moz-animation-fill-mode","layout.css.prefixes.animations"],["-moz-animation-iteration-count","layout.css.prefixes.animations"],["-moz-animation-name","layout.css.prefixes.animations"],["-moz-animation-play-state","layout.css.prefixes.animations"],["-moz-animation-timing-function","layout.css.prefixes.animations"],["-moz-backface-visibility","layout.css.prefixes.transforms"],["-moz-border-image","layout.css.prefixes.border-image"],["-moz-box-sizing","layout.css.prefixes.box-sizing"],["-moz-column-span","layout.css.column-span.enabled"],["-moz-font-feature-settings","layout.css.prefixes.font-features"],["-moz-font-language-override","layout.css.prefixes.font-features"],["-moz-perspective","layout.css.prefixes.transforms"],["-moz-perspective-origin","layout.css.prefixes.transforms"],["-moz-transform","layout.css.prefixes.transforms"],["-moz-transform-origin","layout.css.prefixes.transforms"],["-moz-transform-style","layout.css.prefixes.transforms"],["-moz-transition","layout.css.prefixes.transitions"],["-moz-transition-delay","layout.css.prefixes.transitions"],["-moz-transition-duration","layout.css.prefixes.transitions"],["-moz-transition-property","layout.css.prefixes.transitions"],["-moz-transition-timing-function","layout.css.prefixes.transitions"],["-webkit-align-content","layout.css.prefixes.webkit"],["-webkit-align-items","layout.css.prefixes.webkit"],["-webkit-align-self","layout.css.prefixes.webkit"],["-webkit-animation","layout.css.prefixes.webkit"],["-webkit-animation-delay","layout.css.prefixes.webkit"],["-webkit-animation-direction","layout.css.prefixes.webkit"],["-webkit-animation-duration","layout.css.prefixes.webkit"],["-webkit-animation-fill-mode","layout.css.prefixes.webkit"],["-webkit-animation-iteration-count","layout.css.prefixes.webkit"],["-webkit-animation-name","layout.css.prefixes.webkit"],["-webkit-animation-play-state","layout.css.prefixes.webkit"],["-webkit-animation-timing-function","layout.css.prefixes.webkit"],["-webkit-appearance","layout.css.webkit-appearance.enabled"],["-webkit-backface-visibility","layout.css.prefixes.webkit"],["-webkit-background-clip","layout.css.prefixes.webkit"],["-webkit-background-origin","layout.css.prefixes.webkit"],["-webkit-background-size","layout.css.prefixes.webkit"],["-webkit-border-bottom-left-radius","layout.css.prefixes.webkit"],["-webkit-border-bottom-right-radius","layout.css.prefixes.webkit"],["-webkit-border-image","layout.css.prefixes.webkit"],["-webkit-border-radius","layout.css.prefixes.webkit"],["-webkit-border-top-left-radius","layout.css.prefixes.webkit"],["-webkit-border-top-right-radius","layout.css.prefixes.webkit"],["-webkit-box-align","layout.css.prefixes.webkit"],["-webkit-box-direction","layout.css.prefixes.webkit"],["-webkit-box-flex","layout.css.prefixes.webkit"],["-webkit-box-ordinal-group","layout.css.prefixes.webkit"],["-webkit-box-orient","layout.css.prefixes.webkit"],["-webkit-box-pack","layout.css.prefixes.webkit"],["-webkit-box-shadow","layout.css.prefixes.webkit"],["-webkit-box-sizing","layout.css.prefixes.webkit"],["-webkit-filter","layout.css.prefixes.webkit"],["-webkit-flex","layout.css.prefixes.webkit"],["-webkit-flex-basis","layout.css.prefixes.webkit"],["-webkit-flex-direction","layout.css.prefixes.webkit"],["-webkit-flex-flow","layout.css.prefixes.webkit"],["-webkit-flex-grow","layout.css.prefixes.webkit"],["-webkit-flex-shrink","layout.css.prefixes.webkit"],["-webkit-flex-wrap","layout.css.prefixes.webkit"],["-webkit-justify-content","layout.css.prefixes.webkit"],["-webkit-mask","layout.css.prefixes.webkit"],["-webkit-mask-clip","layout.css.prefixes.webkit"],["-webkit-mask-composite","layout.css.prefixes.webkit"],["-webkit-mask-image","layout.css.prefixes.webkit"],["-webkit-mask-origin","layout.css.prefixes.webkit"],["-webkit-mask-position","layout.css.prefixes.webkit"],["-webkit-mask-position-x","layout.css.prefixes.webkit"],["-webkit-mask-position-y","layout.css.prefixes.webkit"],["-webkit-mask-repeat","layout.css.prefixes.webkit"],["-webkit-mask-size","layout.css.prefixes.webkit"],["-webkit-order","layout.css.prefixes.webkit"],["-webkit-perspective","layout.css.prefixes.webkit"],["-webkit-perspective-origin","layout.css.prefixes.webkit"],["-webkit-text-size-adjust","layout.css.prefixes.webkit"],["-webkit-transform","layout.css.prefixes.webkit"],["-webkit-transform-origin","layout.css.prefixes.webkit"],["-webkit-transform-style","layout.css.prefixes.webkit"],["-webkit-transition","layout.css.prefixes.webkit"],["-webkit-transition-delay","layout.css.prefixes.webkit"],["-webkit-transition-duration","layout.css.prefixes.webkit"],["-webkit-transition-property","layout.css.prefixes.webkit"],["-webkit-transition-timing-function","layout.css.prefixes.webkit"],["-webkit-user-select","layout.css.prefixes.webkit"],["offset-block-end","layout.css.offset-logical-properties.enabled"],["offset-block-start","layout.css.offset-logical-properties.enabled"],["offset-inline-end","layout.css.offset-logical-properties.enabled"],["offset-inline-start","layout.css.offset-logical-properties.enabled"]]
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/devtools/shared/tests/unit/test_css-properties-db.js:run_test:40
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:536
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  -e:null:1
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  exiting test
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  PID 8982 | JavaScript error: /builds/worker/workspace/build/tests/xpcshell/tests/devtools/shared/tests/unit/head_devtools.js, line 47: ReferenceError: DebuggerServer is not defined
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "name"" {file: "resource://devtools/shared/Loader.jsm" line: 224}]"
[task 2018-06-27T15:38:17.758Z] 15:38:17     INFO -  <<<<<<<
[task 2018-06-27T15:38:17.759Z] 15:38:17     INFO -  INFO | Result summary:
[task 2018-06-27T15:38:17.759Z] 15:38:17     INFO -  INFO | Passed: 382
[task 2018-06-27T15:38:17.760Z] 15:38:17  WARNING -  INFO | Failed: 1
[task 2018-06-27T15:38:17.761Z] 15:38:17  WARNING -  One or more unittests failed.
[task 2018-06-27T15:38:17.761Z] 15:38:17     INFO -  INFO | Todo: 0
[task 2018-06-27T15:38:17.762Z] 15:38:17     INFO -  INFO | Retried: 1
[task 2018-06-27T15:38:17.762Z] 15:38:17     INFO -  SUITE-END | took 395s
[task 2018-06-27T15:38:17.763Z] 15:38:17     INFO -  Node moz-http2 server shutting down ...
[task 2018-06-27T15:38:17.805Z] 15:38:17    ERROR - Return code: 1
[task 2018-06-27T15:38:17.806Z] 15:38:17     INFO - TinderboxPrint: xpcshell-xpcshell<br/>382/<em class="testfail">1</em>/0
[task 2018-06-27T15:38:17.806Z] 15:38:17  WARNING - # TBPL FAILURE #
[task 2018-06-27T15:38:17.807Z] 15:38:17  WARNING - setting return code to 2
[task 2018-06-27T15:38:17.807Z] 15:38:17  WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE

Failure push:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0ca9cade77252f5b7a11c1cb8d00d792ee25c78a

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/682adcb25f4e172ed4b73ac6471d77167e4bf7ac

Comment 5

[Emilio Cobos Álvarez (:emilio)]

That one is my fault, from my previous push. That doesn't run on try. I can reland this. Sorry.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48af85db2ec0
remove some dead code in CycleCollectedJSRuntime; r=mccr8

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/48af85db2ec0