1471635 - TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/account/test-ab-whitelist.js | test-ab-whitelist.js::test_address_book_whitelist

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/account/test-ab-whitelist.js | test-ab-whitelist.js::test_address_book_whitelist

First seen: Wed, Jun 27, 2018, 12:47:47

M-C last good: 1c235a552c32ba6c97e6030c497c49f72c
M-C first bad: 9c7bb8874337c2d40aef3d9945b10490a5
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1c235a552c32ba6c97e6030c497c49f72c&tochange=9c7bb8874337c2d40aef3d9945b10490a5

Could be related to bug 1435688 and our port in bug 1471308.

https://taskcluster-artifacts.net/Lirk6uh-T_yZVGpw0ppHxQ/0/public/logs/live_backing.log
says:
INFO -  SUMMARY-UNEXPECTED-FAIL | test-ab-whitelist.js | test-ab-whitelist.js::test_address_book_whitelist
INFO -    EXCEPTION: Should have been checked: 'true' != 'false'.
INFO -      at: test-folder-display-helpers.js line 2913
INFO -         assert_true test-folder-display-helpers.js:2913 11
INFO -         assert_equals test-folder-display-helpers.js:2900 3
INFO -         subtest_check_whitelist_load_and_clear test-ab-whitelist.js:87 5
INFO -         Runner.prototype.wrapper frame.js:579 7

I have the impression that the test opens the junk settings in the AM twice and checks that the selected "white-listed" address books have persisted. Or something similar. I assume something is wrong with the list and the checkboxes.

I'll run the test locally when my build is done.

Richard, can you run what I described manually to see what happens.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1471635.patch

Good we have tests for such thinks. :-)

The problem is, that our bindings are applied after the xul.css bindings and this overrides the listitem[type="checkbox"] binding. I need to add a :not() selector to not apply on listitem[type="checkbox"].

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8988237 [details] [diff] [review]
Bug1471635.patch

Yes, that brings the check-boxes on the panel back and the test also passes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb13a376b2fa
Bug 1471308 follow-up: Don't apply the listitem-iconic binding to listitem[type="checkbox"]. r=jorgk