Closed
Bug 1471646
Opened 6 years ago
Closed 6 years ago
Java checkstyle should enforce OneTopLevelClass
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: gabriel-v, Assigned: gabriel-v)
References
Details
Attachments
(1 file)
Add the line <module name="OneTopLevelClass"/> to the file mobile/android/app/checkstyle.xml, then fix any remaining style errors. See http://checkstyle.sourceforge.net/config_design.html#OneTopLevelClass for documentation.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → tvijiala
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8988462 [details] Bug 1471646 - Add OneTopLevelClass to android checkstyle. https://reviewboard.mozilla.org/r/253746/#review260436 If it's green locally (`mach android checkstyle` passes) and/or on try, it's good for me. Thanks!
Attachment #8988462 -
Flags: review?(nalexander) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Now that bug 1471408 is merged, android checkstyle is passing on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=35cdb492f27377d4522fe2271e9dfffc3e6cee6c
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39ac7d43116c Add OneTopLevelClass to android checkstyle. r=nalexander
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/39ac7d43116c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•