Java checkstyle should enforce OneTopLevelClass

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: gabriel-v, Assigned: gabriel-v)

Tracking

unspecified
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Add the line

    <module name="OneTopLevelClass"/>

to the file mobile/android/app/checkstyle.xml, then fix any remaining style errors.


See http://checkstyle.sourceforge.net/config_design.html#OneTopLevelClass for documentation.
(Assignee)

Updated

6 months ago
Assignee: nobody → tvijiala
Status: NEW → ASSIGNED
(Assignee)

Updated

6 months ago
Blocks: 1471660
Comment hidden (mozreview-request)

Comment 2

6 months ago
mozreview-review
Comment on attachment 8988462 [details]
Bug 1471646 - Add OneTopLevelClass to android checkstyle.

https://reviewboard.mozilla.org/r/253746/#review260436

If it's green locally (`mach android checkstyle` passes) and/or on try, it's good for me.  Thanks!
Attachment #8988462 - Flags: review?(nalexander) → review+
(Assignee)

Updated

5 months ago
Keywords: checkin-needed

Comment 4

5 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39ac7d43116c
Add OneTopLevelClass to android checkstyle. r=nalexander
Keywords: checkin-needed

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/39ac7d43116c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.