Closed Bug 1471646 Opened 2 years ago Closed 2 years ago

Java checkstyle should enforce OneTopLevelClass

Categories

(Firefox for Android :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: gabriel-v, Assigned: gabriel-v)

References

Details

Attachments

(1 file)

Add the line

    <module name="OneTopLevelClass"/>

to the file mobile/android/app/checkstyle.xml, then fix any remaining style errors.


See http://checkstyle.sourceforge.net/config_design.html#OneTopLevelClass for documentation.
Assignee: nobody → tvijiala
Status: NEW → ASSIGNED
Blocks: 1471660
Comment on attachment 8988462 [details]
Bug 1471646 - Add OneTopLevelClass to android checkstyle.

https://reviewboard.mozilla.org/r/253746/#review260436

If it's green locally (`mach android checkstyle` passes) and/or on try, it's good for me.  Thanks!
Attachment #8988462 - Flags: review?(nalexander) → review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39ac7d43116c
Add OneTopLevelClass to android checkstyle. r=nalexander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/39ac7d43116c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.