1471650 - Talos --geckoProfile option should enable webrender-related threads for WebRender profiling

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now the talos --geckoProfile option hard-codes the the "GeckoMain,Compositor" thread list, which doesn't provide much useful information when the talos test is running on one of the webrender-enabled test platforms. If webrender is enabled (generally via MOZ_WEBRENDER=1 in the env) it should use a thread list of "GeckoMain,Compositor,WR,Renderer" instead.

Also, it should actually pass the thread list to the gecko profiler, which it currently doesn't do. The relevant env var MOZ_PROFILER_STARTUP_FILTERS [1] is not set at [2] along with the other vars.

[1] https://searchfox.org/mozilla-central/rev/14cb8f1c238735ba1abe18ad44e39808983c2572/tools/profiler/core/platform.cpp#1971
[2] https://searchfox.org/mozilla-central/rev/14cb8f1c238735ba1abe18ad44e39808983c2572/testing/talos/talos/gecko_profile.py#82

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fee5a115f2b67f525f9c057bacb568dc0ceaed1f

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1471650 - Profile WebRender threads in talos if WebRender is enabled.

Review commit: https://reviewboard.mozilla.org/r/255838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255838/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Is the profile supposed to be automatically symbolicated, or is there extra work that needs to be done for that?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8990786 [details]
Bug 1471650 - Profile WebRender threads in talos if WebRender is enabled.

https://reviewboard.mozilla.org/r/255838/#review262790

one optional nit

::: testing/talos/talos/ffsetup.py:205
(Diff revision 1)
>                           " set")
>          if upload_dir and self.test_config.get('gecko_profile'):
>              self.gecko_profile = GeckoProfile(upload_dir,
>                                                self.browser_config,
> -                                              self.test_config)
> +                                              self.test_config,
> +                                              os.getenv('MOZ_WEBRENDER') == '1')

is this guaranteed to be a string on all operating systems?  we could force it by doing:
str(os.getenv('MOZ_WEBRENDER')) == '1'

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8990786 [details]
Bug 1471650 - Profile WebRender threads in talos if WebRender is enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255838/diff/1-2/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)
> is this guaranteed to be a string on all operating systems?  we could force
> it by doing:
> str(os.getenv('MOZ_WEBRENDER')) == '1'

Good point, updated patch accordingly.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dc02d333988
Profile WebRender threads in talos if WebRender is enabled. r=jmaher

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9dc02d333988