Closed
Bug 1471678
Opened 6 years ago
Closed 6 years ago
Initial (hg, non-Windows) release of a wrapper around Arcanist to better support commit series
Categories
(Conduit :: moz-phab, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Assigned: glob)
References
()
Details
(Keywords: conduit-story, conduit-triaged)
Attachments
(1 file)
To improve the user experience of submitting and updating a series of commits to Phabricator, we'll write a script in Python that wraps Arcanist. This script should require only one invocation to submit or to update a series of commits. It should be noninteractive, that is, everything parsed out of the commit message & metadata and/or provided by command-line options. It should also be easy to specify the commit range.
Reporter | ||
Updated•6 years ago
|
Blocks: remove-arc
Assignee: nobody → glob
Comment 1•6 years ago
|
||
FWIW, git-bz-moz has a bit of code (mostly a regexp) to parse out the reviewer you could use if you want: https://github.com/mozilla/git-bz-moz/blob/master/splitreviewer.py It covers a bunch of common patterns people use at Mozilla, as seen in the unit tests in that file.
thanks mccr8! there's a commitparser lib that's part of mozautomation that i'll probably be using: https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/pylib/mozautomation/mozautomation/commitparser.py it's currently used by mercurial and mozreview. looking at the two libs they take very similar approaches, with some minor differences around what chars are matched. the most notable one is commitparser follows irc and don't permit periods in names. at some point (likely not part of the initial release) we can be more lenient within the arc wrapper and verify nicks by querying phabricator as part of the pre-submission verification phase.
Comment 4•6 years ago
|
||
Comment on attachment 8994412 [details] Bug 1471678 - initial release of arc wrapper Steven MacLeod [:smacleod] has approved the revision. https://phabricator.services.mozilla.com/D2313
Attachment #8994412 -
Flags: review+
Reporter | ||
Comment 5•6 years ago
|
||
Note that the first version of this is now ready to use. At the moment it only supports hg (without mq) but not on Windows. Work continues on this wrapper, and these other features are coming soon; see bugs in Conduit :: Review Wrapper.
Component: Phabricator → Review Wrapper
Reporter | ||
Comment 6•6 years ago
|
||
Morphing this bug to reflect what has landed. https://github.com/mozilla-conduit/review
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Summary: Wrapper around Arcanist to better support commit series → Initial (hg, non-Windows) release of a wrapper around Arcanist to better support commit series
You need to log in
before you can comment on or make changes to this bug.
Description
•