Closed
Bug 1471743
Opened 6 years ago
Closed 6 years ago
remove STRICT_FAKE_SYMLINKS code from nsLocalFileWin
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
858 bytes,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
We don't define STRICT_FAKE_SYMLINKS anywhere, so this is dead code.
Assignee | ||
Comment 1•6 years ago
|
||
`hg grep STRICT_FAKE_SYMLINKS` is still running, but hasn't turned up anything interesting yet, and I don't expect it to. AFAICT, this isn't a weird windows.h define either, so I think we are in the clear to remove this.
Attachment #8988342 -
Flags: review?(erahm)
Comment 2•6 years ago
|
||
Comment on attachment 8988342 [details] [diff] [review] remove STRICT_FAKE_SYMLINKS code from nsLocalFileWin Review of attachment 8988342 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8988342 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4cd236eff0af remove STRICT_FAKE_SYMLINKS code from nsLocalFileWin; r=erahm
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4cd236eff0af
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•