Closed Bug 1471849 Opened 6 years ago Closed 6 years ago

Add a mock for the Services module

Categories

(DevTools :: JSON Viewer, enhancement, P1)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

The Services module is now used in the reps bundle but can't be loaded in the json-viewer.
Since it's only used in the ObjectInspector, which we don't use in the json-viewer, we can mock it.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8988441 [details]
Bug 1471849 - Add mock for Services in json-viewer; .

https://reviewboard.mozilla.org/r/253726/#review260346

Looks good to me.

R+

Thanks Nicolas!

Honza
Attachment #8988441 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df9adbd99113
Add mock for Services in json-viewer; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/df9adbd99113
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: