Closed
Bug 1471850
Opened 7 years ago
Closed 7 years ago
Number picker does not work on custom repeat
Categories
(Calendar :: Dialogs, defect)
Calendar
Dialogs
Tracking
(Not tracked)
RESOLVED
FIXED
6.2
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
4.12 KB,
patch
|
jorgk-bmo
:
review+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
Seen on TB 60 beta 9.
STR:
Create event, repeat: Custom, every: xx days. The arrows don't work.
Also below: Create xxx appointments.
|
Reporter | |
Comment 1•7 years ago
|
||
Not sure whether the assignee automatically gets e-mail.
Flags: needinfo?(richard.marti)
|
Assignee | |
Comment 2•7 years ago
|
||
I thought calendar uses its own bindings for all its time widgets. I checked for all textbox[type="number"] in calendar and added our bindings.css except for the ones in preferences which get this binding already.
I have only added the TB binding because SM has no such binding for textbox[type="number"] and will be probably broken.
Flags: needinfo?(richard.marti)
Attachment #8988555 -
Flags: review?(philipp)
Attachment #8988555 -
Flags: approval-calendar-esr?(philipp)
Attachment #8988555 -
Flags: approval-calendar-beta?(philipp)
|
|
Reporter | |
Comment 3•7 years ago
|
||
Windows build on beta 60 since it's hard to test on trunk:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=80951de652f7eb356407c0bbf46afa473947c91e
| Comment hidden (obsolete) |
|
|
Reporter | |
Comment 5•7 years ago
|
||
Grrrr, spoke too early. On the beta one needs to first remove the installed version, then reset pref extensions.installedDistroAddon.{e2fda1a4-762b-4020-b5ad-a41df1933103}, and upon restart one gets the new version which *IS* working. Sorry about the noise.
|
|
Reporter | |
Comment 6•7 years ago
|
||
Comment on attachment 8988555 [details] [diff] [review]
Bug1471850-textbox-binding.patch
r+a=philipp via IRC. Thanks!
Attachment #8988555 -
Flags: review?(philipp) → review+
|
||
Updated•7 years ago
|
Attachment #8988555 -
Flags: approval-calendar-esr?(philipp)
Attachment #8988555 -
Flags: approval-calendar-esr+
Attachment #8988555 -
Flags: approval-calendar-beta?(philipp)
Attachment #8988555 -
Flags: approval-calendar-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/80d117100cd2
Use our own binding for textbox[type="number"] in Calendar. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•7 years ago
|
Target Milestone: --- → 6.5
|
|
Reporter | |
Comment 8•7 years ago
|
||
TB 60 beta 10, Cal 6.2 (BETA_60_CONTINUATION branch):
https://hg.mozilla.org/releases/comm-beta/rev/0ac6617abd53b35957200cb12841c6e828732d18
Beta (TB 62, Cal 6.4):
https://hg.mozilla.org/releases/comm-beta/rev/2240416be7dd36755e2a83f67118173eb1a2f52f
Target Milestone: 6.5 → 6.2
|
|
Reporter | |
Comment 9•7 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•