1471868 - Backspace deletes wrong chunk when deleting autocompleted URL

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[:Dominik Strohmeier [:dstrohmeier]]

Using backspace to delete autocompleted URL leaves the wrong chunk of characters left in url bar.

To reproduce: Start typing "spo" and wait for the "spotify.com" as autocomplete. Then click backspace to delete the autocompleted chunk will leave "spo" again. When now typing "i" will show "spi" in the url instead of "spoi".

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

From Fennec this bug made it into our InlineAutocompleteEditText component and from their into our other products (e.g. Focus/Klar). We are tracking this in android-components here:
https://github.com/mozilla-mobile/android-components/issues/348

Comment 2

[Chris Peterson [:cpeterson]]

Dominik, which Fennec versions does this bug affect? Is this a recent regression?

Sebastian, should we track this bug (and the android-components bug) as a Focus+GeckoView blocker?

Comment 3

[:Dominik Strohmeier [:dstrohmeier]]

Chris, I don't know which Fennec versions that impacts. I have first noticed it on the release non-GV Firefox Klar version when self-defined autocomplete URLs were introduced. Initially thought that this is an Android thing in general, but figured that it's a Gecko thing.

Sebastian then yesterday found that it exists on Fennec, too.

Does this help? Ping me if you need more info please.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

> Sebastian, should we track this bug (and the android-components bug) as a Focus+GeckoView blocker?

I don't think we should. It's in all our releases. And it has been in Fennec for a very long time probably. I'm surprised we never noticed so far. :)

Comment 5

[Chris Peterson [:cpeterson]]

Interesting how the buggy code was so contagious! :)

Comment 6

[Chris Peterson [:cpeterson]]

P2 because we should fix this soon but it doesn't need to block Focus+GV.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

FYI: This has been fixed in android-components (0.15): https://github.com/mozilla-mobile/android-components/commit/7e56af9adb5a77071d7dc55f77231127993dafb0

A similar patch would need to be applied to the code in mozilla-central if we want to fix that in Fennec too. All other apps use the component and will get the fix with the next update.

Comment 8

[:Dominik Strohmeier [:dstrohmeier]]

In current GV Nightly, the patch introduces a case where backspacing adds another character.

Steps to reproduce:
1) Open GV Nightly and type 'enga' to trigger the autocomplete suggestion for 'engadget.com'
2) Tab backspace twice to detele the autocompleted chunk as well as the last typed letter.

What happens:
First backspace will delete the autocompleted chunk (will give 'enga') , but second backspace will add the first character(s) of the URL to the string (gives 'engaen').

What was to be expected:
First backspace should delete autocomplete chung ('enga') and second backspace should delete last character of the string ('eng')

Comment 9

[Matt Brubeck (:mbrubeck)]

comment 8:

> In current GV Nightly, the patch introduces a case where backspacing adds another character.

I could not reproduce this new bug or the original bug from comment 0 in Focus nightly 6.3 (Build #222191209 Gecko 62.0.20180802174131).

Comment 10

[Matt Brubeck (:mbrubeck)]

Attachment: Bug 1471868 - Don't set composing region after removing autocomplete. r?jchen

Backport of https://github.com/mozilla-mobile/android-components/pull/423

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8998316 [details]
Bug 1471868 - Don't set composing region after removing autocomplete. r?jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 12

[Matt Brubeck (:mbrubeck)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=398c9737a825414ad8022400eb02d95f13a3d8ad

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf959a3fdcfc
Don't set composing region after removing autocomplete. r=jchen

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bf959a3fdcfc

Comment 15

[Chris Peterson [:cpeterson]]

This looks like a longstanding Fennec bug. status-firefox62=wontfix because we don't need to uplift this fix to 62 Beta.

Comment 16

[Stefan Deiac]

Verified as fixed on latest Nightly (2018-08-13) with OnePlus 5T (Android 8.0.0).