1471882 - Bustage on OSX coverage build @nsCodeCoverage.cpp

Status: VERIFIED FIXED

(Testing :: Code Coverage, defect)

Description

[Cosmin Sabou [:CosminS]]

There is bustage on the coverage build on the beta-simulations that look to be related to this https://bugzilla.mozilla.org/show_bug.cgi?id=1470151#c35

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185349458&repo=try&lineNumber=21085

[task 2018-06-28T12:12:52.304Z] 12:12:52     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/tools/code-coverage'
[task 2018-06-28T12:12:52.304Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o nsCodeCoverage.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/tools/code-coverage -I/builds/worker/workspace/build/src/obj-firefox/tools/code-coverage -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/xpcom/base -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -coverage -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.dylib -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror  -MD -MP -MF .deps/nsCodeCoverage.o.pp   /builds/worker/workspace/build/src/tools/code-coverage/nsCodeCoverage.cpp
[task 2018-06-28T12:12:52.304Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/tools/code-coverage/nsCodeCoverage.cpp:59:14: error: unused variable 'cp' [-Werror,-Wunused-variable]
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -    for (auto* cp : ContentParent::AllProcesses(ContentParent::eLive)) {
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -               ^
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/tools/code-coverage/nsCodeCoverage.cpp:33:3: error: bad implicit conversion constructor for 'ProcessCount'
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -    ProcessCount(uint32_t c) : mCount(c) {}
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -    ^
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/tools/code-coverage/nsCodeCoverage.cpp:33:3: note: consider adding the explicit keyword to the constructor
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  2 errors generated.
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1031: recipe for target 'nsCodeCoverage.o' failed
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  make[4]: *** [nsCodeCoverage.o] Error 1
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/tools/code-coverage'
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'tools/code-coverage/target' failed
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  make[3]: *** [tools/code-coverage/target] Error 2
[task 2018-06-28T12:12:52.309Z] 12:12:52     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2018-06-28T12:12:52.586Z] 12:12:52     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/accessible/html'
[task 2018-06-28T12:12:52.587Z] 12:12:52     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_accessible_html0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/accessible/html -I/builds/worker/workspace/build/src/obj-firefox/accessible/html -I/builds/worker/workspace/build/src/accessible/base -I/builds/worker/workspace/build/src/accessible/generic -I/builds/worker/workspace/build/src/accessible/xpcom -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/tables -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/accessible/mac -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -coverage -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.dylib -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_accessible_html0.o.pp   /builds/worker/workspace/build/src/obj-firefox/accessible/html/Unified_cpp_accessible_html0.cpp
[task 2018-06-28T12:12:52.587Z] 12:12:52     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/accessible/html'

Comment 1

[Marco Castelluccio [:marco]]

We'll fix this, but we shouldn't run Mac coverage builds in beta simulations.

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1471882 - Fix build bustage on nsCodeCoverage.cpp

- Add explicit keyword on ProcessCount ctor
- Fix an unused variable in a loop

Comment 3

[Phabricator Automation]

Comment on attachment 8988545 [details]
Bug 1471882 - Fix build bustage on nsCodeCoverage.cpp

Marco Castelluccio [:marco] has approved the revision.

https://phabricator.services.mozilla.com/D1864

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47b086b8fa06
Fix build bustage on nsCodeCoverage.cpp r=marco

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/47b086b8fa06

Comment 6

[Andreea Pavel [:apavel]]

This no longer occurs on the latest beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4f387e0b4e31297f1d305cf8c419627ad68b679&selectedJob=185349458

Comment 7

[Marco Castelluccio [:marco]]

(In reply to Andreea Pavel [:apavel] from comment #6)
> This no longer occurs on the latest beta-sim:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=b4f387e0b4e31297f1d305cf8c419627ad68b679&selectedJob=1
> 85349458

Thanks for verifying! I'll file a bug for stopping to run ccov builds on beta-sim.