[mozsystemmonitor] Add test manifest to testing/mozbase/moz.build

RESOLVED FIXED in Firefox 68

Status

enhancement
P3
normal
RESOLVED FIXED
Last year
4 months ago

People

(Reporter: davehunt, Assigned: nikkis, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Version 3
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

The tests for mozsystemmonitor are not currently being run because the manifest file is not listed in testing/mozbase/moz.build. We should add the manifest, and skip any tests that are not passing against Python 3.
No longer blocks: 1428716
Priority: -- → P3

Hi Dave.
I'm an Outreachy applicant.
I have added the manifest file to moz.build.
I have looked into using @unittest.skipIf(condition, reason) and @unittest.expectedFailure, but I am unsure how to specify skipping if it doesn't pass against Python 3. Is there a way to state this in the condition? Have tried to find similar examples but with no luck.
Can you please give me some advice?
Thank you!

Currently, tests in mozsystemmonitor are skipped because the manifest is missing
from mozbase/moz.build. This has now been added.

For the moment, this patch also skips the test if run against Python 3. This is
not ideal - a better fix may be setting the unittest.skipIf condition to skip
if the there is simply a failure when run with Python 3.

Pushed by dhunt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac9b05fb0fdf
[mozsystemmonitor] Add test manifest to testing/mozbase/moz.build r=davehunt
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → nikkisharpley
You need to log in before you can comment on or make changes to this bug.