1471951 - Support Talkback editing actions (select/copy/paste)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P1)

Description

[Eitan Isaacson [:eeejay]]

This is done in the local context menu, under the "Editing" sub menu. It has the following options:

* Move cursor to beginning
* Move cursor to end
* Paste
* Select all
* Start/stop selection mode

The last option makes that when you move the caret by text granularity it grows or shrinks the selection range.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Support set selection and clipboard actions (1/2). r?yzen r?jchen

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Support expand selection with caret (2/2). r?yzen r?jchen

This will benefit from the line navigation changes in bug 1474688 as well. So that is great!

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8991168 [details] [diff] [review]
Support set selection and clipboard actions (1/2). r?yzen r?jchen

Review of attachment 8991168 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, a nit regarding prefering const to let anywhere we do not reassign variables in JS.

::: accessible/jsat/EventManager.jsm
@@ +213,5 @@
> +          if (acc.selectionCount) {
> +            let [startSel, endSel] = Utils.getTextSelection(acc);
> +            let fromIndex = startSel == caretOffset ? endSel : startSel;
> +            this.present(Presentation.textSelectionChanged(
> +              acc.getText(0, -1), fromIndex, caretOffset, 0, 0,

looks like here the only difference is fromIndex vs caretOffset in the else statement. can we just have one if () no else where we set fromIndex if acc.selectionCount is truthy otherwise defaulting to the value of caretOffset?

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8991169 [details] [diff] [review]
Support expand selection with caret (2/2). r?yzen r?jchen

Review of attachment 8991169 [details] [diff] [review]:
-----------------------------------------------------------------

thanks! same suggestions about const over let where possible.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a682e5c249b8
Support set selection and clipboard actions (1/2). r=yzen r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/78356edc6a51
Support expand selection with caret (2/2). r=yzen r=jchen

Comment 6

[Andreea Pavel [:apavel]]

Backed out for eslint failure at builds/worker/checkouts/gecko/accessible/jsat/ContentControl.jsm:25

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=78356edc6a51aa44e8ebe92a6c8a1e5f5bdf2798

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=187876666&repo=mozilla-inbound&lineNumber=247

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/b8c11e672239fa18067c71b6aebb69e0d2abd4d2

Comment 7

[Eitan Isaacson [:eeejay]]

That's silly. I'll fix and repush. Sorry!

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Support set selection and clipboard actions (1/2). r=yzen

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Support expand selection with caret (2/2). r=yzen

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/590ba4c10edd
Support set selection and clipboard actions (1/2). r=yzen r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb7687c97e1f
Support expand selection with caret (2/2). r=yzen r=jchen

Comment 11

[Andreea Pavel [:apavel]]

Backed out for failing android at org.mozilla.geckoview.test.AccessibilityTest.testClipboard

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=cb7687c97e1f8ab7e233469823eb89afd8ba6322

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=187895554&repo=mozilla-inbound&lineNumber=1475

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/7236e824c48b66151073c022f81a696c3106f080

Comment 12

[Chris Peterson [:cpeterson]]

[geckoview:klar] so this bug will be triaged as a potential Focus+GV blocker.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1839e4b613bd
Support set selection and clipboard actions (1/2). r=yzen r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/d75a549c4e93
Support expand selection with caret (2/2). r=yzen r=jchen

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1839e4b613bd
https://hg.mozilla.org/mozilla-central/rev/d75a549c4e93

Comment 15

[Chris Peterson [:cpeterson]]

status-firefox62=wontfix because Eitan recommends that we do not uplift this fix to GV 62 beta.