Closed
Bug 1471990
Opened 6 years ago
Closed 6 years ago
[tryselect] Implement |mach try again|
Categories
(Testing :: General, enhancement)
Tracking
(firefox-esr60 fixed, firefox63 fixed)
RESOLVED
FIXED
mozilla63
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
One of the big downsides to |mach try fuzzy| is that if you use the interactive finder, there's no way to repeat your last action. If you want to run the same push again, you have to manually re-select all the same tasks a second time. It is possible to save presets, but this is fairly heavy-weight and (more) permanent. Sometimes you just want to re-run a push a few times and forget about it. It's also possible to craft the query on the command line with -q, but then you don't get the immediate visual feedback, so you can't be sure that you typed out the right things without actually pushing. I've had an idea to implement |mach try again| for awhile now. Everytime you generate a try_task_config.json via `fuzzy`, `empty` or any other subcommands that may exist in the future, it'll get stored in a history file under ~/.mozbuild. Then running |mach try again| will simply re-run the most recent try_task_config.json. You'll also be able to view the whole history via |mach try again --list| and select a specific one via |mach try again --index <index>|. Example usage will be: $ ./mach try fuzzy <select a bunch of tasks> $ ./mach try again <re-pushes exact same set of tasks> I currently have my local patches based on top of bug 1413922.
Assignee | ||
Comment 1•6 years ago
|
||
One of the big downsides to |mach try fuzzy| is that if you use the interactive finder, there's no way to repeat your last action. If you want to run the same push again, you have to manually re-select all the same tasks a second time. It is possible to save presets, but this is fairly heavy-weight and (more) permanent. Sometimes you just want to re-run a push a few times and forget about it. It's also possible to craft the query on the command line with -q, but then you don't get the immediate visual feedback, so you can't be sure that you typed out the right things without actually pushing. With |mach try again|, everytime you generate a try_task_config.json via 'fuzzy', 'empty' or any other subcommands that may exist in the future, it'll get stored in a history file under ~/.mozbuild. Then running |mach try again| will simply re-run the most recent try_task_config.json. You'll also be able to view the whole history via |mach try again --list| and select a specific try_task_config.json (i.e not the most recent one) via |mach try again --index <index>|. Example usage will be: $ ./mach try fuzzy <select a bunch of tasks> $ ./mach try again <re-pushes exact same set of tasks> MozReview-Commit-ID: 3EZjVCy08uq Depends on D1808.
Comment 2•6 years ago
|
||
Comment on attachment 8988582 [details] Bug 1471990 - Implement |mach try again| to repeat your last 'try_task_config.json' try push Geoff Brown [:gbrown] has approved the revision. https://phabricator.services.mozilla.com/D1867
Attachment #8988582 -
Flags: review+
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c423f75eb77 Implement |mach try again| to repeat your last 'try_task_config.json' try push r=gbrown
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8c423f75eb77
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 5•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/1e622a1af606
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•