Closed Bug 1472081 Opened 2 years ago Closed 2 years ago

election.gov.np - Override window.sidebar with something falsey

Categories

(Web Compatibility :: Interventions, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: denschub, Assigned: denschub)

References

Details

(Whiteboard: [sitepatch-built])

Attachments

(1 file)

As per this comment https://webcompat.com/issues/11622#issuecomment-389476742, overriding window.sidebar with something that evaluates to false gets the form elements working again.
Attached patch Pull Request #25Splinter Review
This PR implements a site patch to override window.sidebar with false, so that the form elements are usable again.
Attachment #8988659 - Flags: review?(wisniewskit)
Comment on attachment 8988659 [details] [diff] [review]
Pull Request #25

Review of attachment 8988659 [details] [diff] [review]:
-----------------------------------------------------------------

r+ (notes on GitHub)
Attachment #8988659 - Attachment is patch: true
Attachment #8988659 - Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8988659 - Flags: review?(wisniewskit) → review+
Blocks: 1481395
Site patch is landed in our repo on GitHub, so this can be closed. Landing the site patches (and eventually updating Release users via GoFaster) is tracked in bug 1481395.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: [sitepatch-built]
You need to log in before you can comment on or make changes to this bug.