1472105 - Back out bug 1427700 from Beta for bug 1463809

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P1)

Description

[:Paolo Amadini]

Per bug 1463809 comment 10.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1472105 - Back out changeset e933d5d558ec (bug 1427700) for bug 1463809.

Review commit: https://reviewboard.mozilla.org/r/253894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253894/

Comment 2

[:Paolo Amadini]

Comment on attachment 8988673 [details]
Bug 1472105 - Back out changeset e933d5d558ec (bug 1427700) for bug 1463809.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1427700
[User impact if declined]: Bug 1463809
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Reverts to a known good state
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: Reverts to a known good state
[String changes made/needed]: None

Comment 3

[:Paolo Amadini]

I've asked Gijs for a rubberstamp, but already requested approval in the meantime since it's a trivial uplift.

This should only land in Beta, we're working on bug 1463809 in Nightly.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8988673 [details]
Bug 1472105 - Back out changeset e933d5d558ec (bug 1427700) for bug 1463809.

https://reviewboard.mozilla.org/r/253894/#review260658

rs=me in that this is the correct patch to do a backout, but I don't know anything about this code, or if the cure is worse than the disease here... so I mean, if you wanted buy-in on this backout, I would suggest talking to jhorak or stransky...

Comment 5

[:Paolo Amadini]

Thanks! Yes, this is just a rubberstamp, Jan and I already talked in bug 1463809.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8988673 [details]
Bug 1472105 - Back out changeset e933d5d558ec (bug 1427700) for bug 1463809.

OK, from the discussion in bug 1463809 and gijs's approval I think this is fine to land on mozilla-beta. It should end up in beta 5 early next week.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ed2507b0976