1472163 - Remove sync/async blocklist load probe

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[:Gijs (he/him)]

Bug 1454378 removed all the code that recorded this telemetry, because we no longer ever load the list synchronously. We should remove the histogram from Histograms.json . This involves removing this block of JSON:

https://searchfox.org/mozilla-central/rev/d2966246905102b36ef5221b0e3cbccf7ea15a86/toolkit/components/telemetry/Histograms.json#208-216

Comment 1

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #0)
> Bug 1454378 removed all the code that recorded this telemetry, because we no
> longer ever load the list synchronously. We should remove the histogram from
> Histograms.json . This involves removing this block of JSON:
> 
> https://searchfox.org/mozilla-central/rev/
> d2966246905102b36ef5221b0e3cbccf7ea15a86/toolkit/components/telemetry/
> Histograms.json#208-215

Oops, fixed link:
https://searchfox.org/mozilla-central/rev/d2966246905102b36ef5221b0e3cbccf7ea15a86/toolkit/components/telemetry/Histograms.json#208-215

Comment 2

[Liam]

Hi! I would like to acquire some experience contributing to the Mozilla codebase by taking this issue. Could I be assigned?

Comment 3

[:Gijs (he/him)]

(In reply to Liam from comment #2)
> Hi! I would like to acquire some experience contributing to the Mozilla
> codebase by taking this issue. Could I be assigned?

Sure! We generally assign first bugs after you put up your first patch. In case you need help getting started:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

tells you how to get the source and build it. Feel free to ask questions on here if you get stuck. I'm traveling this weekend so you may not get a response from me immediately - apologies in advance - but you could also try asking on IRC in #introduction (there's a link in that first link) where other people may be around who are able to help. :-)

Comment 4

[Liam]

Attachment: Removed histogram from Histograms.json (Bug 1472163)

Review commit: https://reviewboard.mozilla.org/r/254064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254064/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8988955 [details]
Removed histogram from Histograms.json (Bug 1472163)

https://reviewboard.mozilla.org/r/254064/#review260828

Looks great, thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78472262694a
Removed histogram from Histograms.json r=Gijs

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/78472262694a