1472201 - Vendor pytest 3.6.2 and dependencies

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1472201 - Vendor pytest 3.6.2 and dependencies;

Review commit: https://reviewboard.mozilla.org/r/253948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253948/

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8988738 [details]
Bug 1472201 - Vendor pytest 3.6.2 and dependencies;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253948/diff/1-2/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8988738 [details]
Bug 1472201 - Vendor pytest 3.6.2 and dependencies;

https://reviewboard.mozilla.org/r/253948/#review260672


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: config/mozunit/mozunit/mozunit.py:12
(Diff revision 1)
>  import os
>  import sys
>  import unittest
>  from unittest import TextTestRunner as _TestRunner, TestResult as _TestResult
>  
> +import buildconfig

Error: 'buildconfig' imported but unused [flake8: F401]

Comment 4

[Code Review Bot [:reviewbot]]

Comment on attachment 8988738 [details]
Bug 1472201 - Vendor pytest 3.6.2 and dependencies;

https://reviewboard.mozilla.org/r/253948/#review260674


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: config/mozunit/mozunit/mozunit.py:12
(Diff revision 2)
>  import os
>  import sys
>  import unittest
>  from unittest import TextTestRunner as _TestRunner, TestResult as _TestResult
>  
> +import buildconfig

Error: 'buildconfig' imported but unused [flake8: F401]

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8988738 [details]
Bug 1472201 - Vendor pytest 3.6.2 and dependencies;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253948/diff/2-3/

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8988738 [details]
Bug 1472201 - Vendor pytest 3.6.2 and dependencies;

https://reviewboard.mozilla.org/r/253948/#review260720

Lgtm!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a566524dd127
Vendor pytest 3.6.2 and dependencies; r=ahal

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a566524dd127